small README improvements #108

Merged
merged 5 commits into from Mar 4, 2014

Conversation

Projects
None yet
3 participants
Contributor

Mithgol commented Feb 28, 2014

Three minor changes in README.markdown are suggested in this pull request.

Mithgol added some commits Feb 28, 2014

@Mithgol Mithgol create a hyperlink to LICENSE.markdown be893d0
@Mithgol Mithgol . d1fb85c
@Mithgol Mithgol modest heading levels
“JSZip” becomes H2, any other header becomes H3.

(GitHub's H1 headers are about 37px and that's huge.)
efe1f76

@Stuk Stuk and 1 other commented on an outdated diff Feb 28, 2014

README.markdown
@@ -1,10 +1,9 @@
-JSZip
-=====
+## JSZip
@Stuk

Stuk Feb 28, 2014

Owner

I'd prefer to keep this as a top level heading, as it is the title of this file.

@Mithgol

Mithgol Feb 28, 2014

Contributor

Ok, reverted this line.

@Mithgol Mithgol keep “JSZip” on the H1 heading level
(Partial revert of the previous commit.)
ae8a6ee
Collaborator

dduponchel commented Mar 3, 2014

Seems good to me. @Stuk do you see any other issue ?

@Stuk Stuk and 1 other commented on an outdated diff Mar 3, 2014

README.markdown
[![Build Status](https://secure.travis-ci.org/Stuk/jszip.png?branch=master)](http://travis-ci.org/Stuk/jszip)
[![Selenium Test Status](https://saucelabs.com/browser-matrix/jszip.svg)](https://saucelabs.com/u/jszip)
-License
-=======
+### License
@Stuk

Stuk Mar 3, 2014

Owner

Now that the header is back to a level 1, these should remain at level 2. Sorry.

@Mithgol

Mithgol Mar 4, 2014

Contributor

Done.

Stuk merged commit 1786f51 into Stuk:master Mar 4, 2014

1 check passed

default The Travis CI build passed
Details
Owner

Stuk commented Mar 4, 2014

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment