diff --git a/bundle/regal/rules/bugs/constant_condition_test.rego b/bundle/regal/rules/bugs/constant_condition_test.rego index bbe6254b..908fff75 100644 --- a/bundle/regal/rules/bugs/constant_condition_test.rego +++ b/bundle/regal/rules/bugs/constant_condition_test.rego @@ -2,7 +2,6 @@ package regal.rules.bugs_test import future.keywords.if -import data.regal.ast import data.regal.config import data.regal.rules.bugs.common_test.report diff --git a/bundle/regal/rules/bugs/not_equals_in_loop_test.rego b/bundle/regal/rules/bugs/not_equals_in_loop_test.rego index 08039b42..664a3c71 100644 --- a/bundle/regal/rules/bugs/not_equals_in_loop_test.rego +++ b/bundle/regal/rules/bugs/not_equals_in_loop_test.rego @@ -2,7 +2,6 @@ package regal.rules.bugs_test import future.keywords.if -import data.regal.ast import data.regal.rules.bugs.common_test.report import data.regal.rules.bugs.common_test.report_with_fk diff --git a/bundle/regal/rules/bugs/rule_named_if_test.rego b/bundle/regal/rules/bugs/rule_named_if_test.rego index 6adcba30..c015016d 100644 --- a/bundle/regal/rules/bugs/rule_named_if_test.rego +++ b/bundle/regal/rules/bugs/rule_named_if_test.rego @@ -2,7 +2,6 @@ package regal.rules.bugs_test import future.keywords.if -import data.regal.ast import data.regal.config import data.regal.rules.bugs.common_test.report diff --git a/bundle/regal/rules/bugs/rule_shadows_builtin_test.rego b/bundle/regal/rules/bugs/rule_shadows_builtin_test.rego index 7e254d7f..99d0127a 100644 --- a/bundle/regal/rules/bugs/rule_shadows_builtin_test.rego +++ b/bundle/regal/rules/bugs/rule_shadows_builtin_test.rego @@ -2,9 +2,7 @@ package regal.rules.bugs_test import future.keywords.if -import data.regal.ast import data.regal.config -import data.regal.rules.bugs import data.regal.rules.bugs.common_test.report test_fail_rule_name_shadows_builtin if { diff --git a/bundle/regal/rules/bugs/top_level_iteration_test.rego b/bundle/regal/rules/bugs/top_level_iteration_test.rego index 185b89c6..dab108e9 100644 --- a/bundle/regal/rules/bugs/top_level_iteration_test.rego +++ b/bundle/regal/rules/bugs/top_level_iteration_test.rego @@ -2,9 +2,7 @@ package regal.rules.bugs_test import future.keywords.if -import data.regal.ast import data.regal.config -import data.regal.rules.bugs import data.regal.rules.bugs.common_test.report_with_fk test_fail_top_level_iteration_wildcard if { diff --git a/bundle/regal/rules/bugs/unused_return_value_test.rego b/bundle/regal/rules/bugs/unused_return_value_test.rego index 4833dcfb..d692cb1e 100644 --- a/bundle/regal/rules/bugs/unused_return_value_test.rego +++ b/bundle/regal/rules/bugs/unused_return_value_test.rego @@ -2,9 +2,7 @@ package regal.rules.bugs_test import future.keywords.if -import data.regal.ast import data.regal.config -import data.regal.rules.bugs import data.regal.rules.bugs.common_test.report_with_fk test_fail_unused_return_value if { diff --git a/bundle/regal/rules/idiomatic/custom_has_key_construct.rego b/bundle/regal/rules/idiomatic/custom_has_key_construct.rego index 545ebf92..a9bf58c2 100644 --- a/bundle/regal/rules/idiomatic/custom_has_key_construct.rego +++ b/bundle/regal/rules/idiomatic/custom_has_key_construct.rego @@ -4,7 +4,6 @@ import future.keywords.contains import future.keywords.if import future.keywords.in -import data.regal.ast import data.regal.config import data.regal.result @@ -31,7 +30,7 @@ report contains violation if { terms[0].value[0].type == "var" terms[0].value[0].value == "eq" - [var, ref] := normalize_eq_terms(terms) + [_, ref] := normalize_eq_terms(terms) ref.value[0].type == "var" ref.value[0].value in arg_names diff --git a/bundle/regal/rules/idiomatic/custom_has_key_construct_test.rego b/bundle/regal/rules/idiomatic/custom_has_key_construct_test.rego index dab670b7..d4b2e3f2 100644 --- a/bundle/regal/rules/idiomatic/custom_has_key_construct_test.rego +++ b/bundle/regal/rules/idiomatic/custom_has_key_construct_test.rego @@ -2,9 +2,7 @@ package regal.rules.idiomatic_test import future.keywords.if -import data.regal.ast import data.regal.config -import data.regal.rules.idiomatic import data.regal.rules.idiomatic.common_test.report test_fail_unnecessary_construct_in if { diff --git a/bundle/regal/rules/idiomatic/custom_in_construct.rego b/bundle/regal/rules/idiomatic/custom_in_construct.rego index 4e2dc7a1..503a297e 100644 --- a/bundle/regal/rules/idiomatic/custom_in_construct.rego +++ b/bundle/regal/rules/idiomatic/custom_in_construct.rego @@ -4,7 +4,6 @@ import future.keywords.contains import future.keywords.if import future.keywords.in -import data.regal.ast import data.regal.config import data.regal.result diff --git a/bundle/regal/rules/idiomatic/custom_in_construct_test.rego b/bundle/regal/rules/idiomatic/custom_in_construct_test.rego index 42d46dd0..b9fb5593 100644 --- a/bundle/regal/rules/idiomatic/custom_in_construct_test.rego +++ b/bundle/regal/rules/idiomatic/custom_in_construct_test.rego @@ -2,9 +2,7 @@ package regal.rules.idiomatic_test import future.keywords.if -import data.regal.ast import data.regal.config -import data.regal.rules.idiomatic import data.regal.rules.idiomatic.common_test.report test_fail_unnecessary_construct_in if { diff --git a/bundle/regal/rules/imports/avoid_importing_input_test.rego b/bundle/regal/rules/imports/avoid_importing_input_test.rego index 4056c3c2..1f3f307d 100644 --- a/bundle/regal/rules/imports/avoid_importing_input_test.rego +++ b/bundle/regal/rules/imports/avoid_importing_input_test.rego @@ -2,7 +2,6 @@ package regal.rules.imports_test import future.keywords.if -import data.regal.ast import data.regal.config import data.regal.rules.imports.common_test.report diff --git a/bundle/regal/rules/imports/implicit_future_keywords_test.rego b/bundle/regal/rules/imports/implicit_future_keywords_test.rego index 3e358b58..0e049f33 100644 --- a/bundle/regal/rules/imports/implicit_future_keywords_test.rego +++ b/bundle/regal/rules/imports/implicit_future_keywords_test.rego @@ -2,9 +2,7 @@ package regal.rules.imports_test import future.keywords.if -import data.regal.ast import data.regal.config -import data.regal.rules.imports import data.regal.rules.imports.common_test.report test_fail_future_keywords_import_wildcard if { diff --git a/bundle/regal/rules/imports/import_shadows_import_test.rego b/bundle/regal/rules/imports/import_shadows_import_test.rego index f5577135..93de305e 100644 --- a/bundle/regal/rules/imports/import_shadows_import_test.rego +++ b/bundle/regal/rules/imports/import_shadows_import_test.rego @@ -2,9 +2,7 @@ package regal.rules.imports_test import future.keywords.if -import data.regal.ast import data.regal.config -import data.regal.rules.imports import data.regal.rules.imports.common_test.report test_fail_duplicate_import if { diff --git a/bundle/regal/rules/imports/redundant_alias_test.rego b/bundle/regal/rules/imports/redundant_alias_test.rego index 6efb545e..ab0c5c4d 100644 --- a/bundle/regal/rules/imports/redundant_alias_test.rego +++ b/bundle/regal/rules/imports/redundant_alias_test.rego @@ -2,9 +2,7 @@ package regal.rules.imports_test import future.keywords.if -import data.regal.ast import data.regal.config -import data.regal.rules.imports import data.regal.rules.imports.common_test.report test_fail_redundant_alias if { diff --git a/bundle/regal/rules/imports/redundant_data_import_test.rego b/bundle/regal/rules/imports/redundant_data_import_test.rego index 7729364a..4fe05f8f 100644 --- a/bundle/regal/rules/imports/redundant_data_import_test.rego +++ b/bundle/regal/rules/imports/redundant_data_import_test.rego @@ -2,9 +2,7 @@ package regal.rules.imports_test import future.keywords.if -import data.regal.ast import data.regal.config -import data.regal.rules.imports import data.regal.rules.imports.common_test.report test_fail_import_data if { diff --git a/bundle/regal/rules/style/avoid_get_and_list_prefix_test.rego b/bundle/regal/rules/style/avoid_get_and_list_prefix_test.rego index 7275713b..ee3b3f11 100644 --- a/bundle/regal/rules/style/avoid_get_and_list_prefix_test.rego +++ b/bundle/regal/rules/style/avoid_get_and_list_prefix_test.rego @@ -2,9 +2,7 @@ package regal.rules.style_test import future.keywords.if -import data.regal.ast import data.regal.config -import data.regal.rules.style import data.regal.rules.style.common_test.report test_fail_rule_name_starts_with_get if { diff --git a/bundle/regal/rules/style/external_reference_test.rego b/bundle/regal/rules/style/external_reference_test.rego index e0cb4df9..988a713c 100644 --- a/bundle/regal/rules/style/external_reference_test.rego +++ b/bundle/regal/rules/style/external_reference_test.rego @@ -2,9 +2,7 @@ package regal.rules.style_test import future.keywords.if -import data.regal.ast import data.regal.config -import data.regal.rules.style import data.regal.rules.style.common_test.report test_fail_function_references_input if { diff --git a/bundle/regal/rules/style/line_length.rego b/bundle/regal/rules/style/line_length.rego index 623695eb..389d0693 100644 --- a/bundle/regal/rules/style/line_length.rego +++ b/bundle/regal/rules/style/line_length.rego @@ -4,7 +4,6 @@ import future.keywords.contains import future.keywords.if import future.keywords.in -import data.regal.ast import data.regal.config import data.regal.result diff --git a/bundle/regal/rules/style/line_length_test.rego b/bundle/regal/rules/style/line_length_test.rego index 4c6e8959..09a762ce 100644 --- a/bundle/regal/rules/style/line_length_test.rego +++ b/bundle/regal/rules/style/line_length_test.rego @@ -2,9 +2,7 @@ package regal.rules.style_test import future.keywords.if -import data.regal.ast import data.regal.config -import data.regal.rules.style import data.regal.rules.style.common_test.report test_fail_line_too_long if { diff --git a/bundle/regal/rules/style/prefer_snake_case_test.rego b/bundle/regal/rules/style/prefer_snake_case_test.rego index 145eb9ad..912f73e6 100644 --- a/bundle/regal/rules/style/prefer_snake_case_test.rego +++ b/bundle/regal/rules/style/prefer_snake_case_test.rego @@ -2,9 +2,7 @@ package regal.rules.style_test import future.keywords.if -import data.regal.ast import data.regal.config -import data.regal.rules.style import data.regal.rules.style.common_test.report snake_case_violation := { diff --git a/bundle/regal/rules/style/todo_comment.rego b/bundle/regal/rules/style/todo_comment.rego index 09c13bef..294849f2 100644 --- a/bundle/regal/rules/style/todo_comment.rego +++ b/bundle/regal/rules/style/todo_comment.rego @@ -4,7 +4,6 @@ import future.keywords.contains import future.keywords.if import future.keywords.in -import data.regal.ast import data.regal.config import data.regal.result diff --git a/bundle/regal/rules/style/todo_comment_test.rego b/bundle/regal/rules/style/todo_comment_test.rego index d7007586..1580654e 100644 --- a/bundle/regal/rules/style/todo_comment_test.rego +++ b/bundle/regal/rules/style/todo_comment_test.rego @@ -2,9 +2,7 @@ package regal.rules.style_test import future.keywords.if -import data.regal.ast import data.regal.config -import data.regal.rules.style import data.regal.rules.style.common_test.report test_fail_todo_comment if { diff --git a/bundle/regal/rules/style/unconditional_assignment.rego b/bundle/regal/rules/style/unconditional_assignment.rego index 72009517..ebf395b9 100644 --- a/bundle/regal/rules/style/unconditional_assignment.rego +++ b/bundle/regal/rules/style/unconditional_assignment.rego @@ -4,7 +4,6 @@ import future.keywords.contains import future.keywords.if import future.keywords.in -import data.regal.ast import data.regal.config import data.regal.result diff --git a/bundle/regal/rules/style/unconditional_assignment_test.rego b/bundle/regal/rules/style/unconditional_assignment_test.rego index bb1cd5aa..46a5bcfb 100644 --- a/bundle/regal/rules/style/unconditional_assignment_test.rego +++ b/bundle/regal/rules/style/unconditional_assignment_test.rego @@ -2,9 +2,7 @@ package regal.rules.style_test import future.keywords.if -import data.regal.ast import data.regal.config -import data.regal.rules.style import data.regal.rules.style.common_test.report test_fail_unconditional_assignment_in_body if { diff --git a/bundle/regal/rules/style/use_assignment_operator.rego b/bundle/regal/rules/style/use_assignment_operator.rego index 695b47cf..2475e66d 100644 --- a/bundle/regal/rules/style/use_assignment_operator.rego +++ b/bundle/regal/rules/style/use_assignment_operator.rego @@ -4,10 +4,8 @@ import future.keywords.contains import future.keywords.if import future.keywords.in -import data.regal.ast import data.regal.config import data.regal.result -import data.regal.util # Some cases blocked by https://github.com/StyraInc/regal/issues/6 - e.g: # diff --git a/bundle/regal/rules/style/use_assignment_operator_test.rego b/bundle/regal/rules/style/use_assignment_operator_test.rego index bf2c6bf2..3a67b238 100644 --- a/bundle/regal/rules/style/use_assignment_operator_test.rego +++ b/bundle/regal/rules/style/use_assignment_operator_test.rego @@ -2,9 +2,7 @@ package regal.rules.style_test import future.keywords.if -import data.regal.ast import data.regal.config -import data.regal.rules.style import data.regal.rules.style.common_test.report test_fail_unification_in_default_assignment if { diff --git a/bundle/regal/rules/style/use_in_operator_test.rego b/bundle/regal/rules/style/use_in_operator_test.rego index 12b1acab..e3b0729f 100644 --- a/bundle/regal/rules/style/use_in_operator_test.rego +++ b/bundle/regal/rules/style/use_in_operator_test.rego @@ -2,9 +2,7 @@ package regal.rules.style_test import future.keywords.if -import data.regal.ast import data.regal.config -import data.regal.rules.style import data.regal.rules.style.common_test.report test_fail_use_in_operator_string_lhs if { diff --git a/bundle/regal/rules/testing/todo_test.rego b/bundle/regal/rules/testing/todo_test.rego index cc7ad5a7..5045afa5 100644 --- a/bundle/regal/rules/testing/todo_test.rego +++ b/bundle/regal/rules/testing/todo_test.rego @@ -4,7 +4,6 @@ import future.keywords.contains import future.keywords.if import future.keywords.in -import data.regal.ast import data.regal.config import data.regal.result