Remove uitable dependency #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compact format now uses a table with headings and borders as that actually looks better than what it used to, but the pretty format looks just as before. An unexpected optimization, I must say, but: ``` regal-table lint e2e/testdata/violations/most_violations.rego ran 1.09 ± 0.02 times faster than regal-main lint e2e/testdata/violations/most_violations.rego ``` That'll only benefit projects with many violations though ;) Fixes #479 Signed-off-by: Anders Eknert <anders@styra.com>
srenatus
approved these changes
Nov 17, 2023
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
The compact format now uses a table with headings and borders as that actually looks better than what it used to, but the pretty format looks just as before. An unexpected optimization, I must say, but: ``` regal-table lint e2e/testdata/violations/most_violations.rego ran 1.09 ± 0.02 times faster than regal-main lint e2e/testdata/violations/most_violations.rego ``` That'll only benefit projects with many violations though ;) Fixes StyraInc#479 Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compact format now uses a table with headings and borders as that actually looks better than what it used to, but the pretty format looks just as before.
An unexpected optimization, I must say, but:
That'll only benefit projects with many violations though ;)
Fixes #479