DAMD-108: Please add spectrograph to pfsDesign/pfsConfig file #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We might like to have this function in pfs_utils, but we'd also like to avoid adding dependencies to datamodel.
This makes it easy to select data from a particular spectrograph.
| @@ -7,7 +7,7 @@ | |||
| import numpy as np | |||
|
|
|||
| __all__ = ("calculatePfsVisitHash", "createHash", "astropyHeaderToDict", "astropyHeaderFromDict", | |||
| "wraparoundNVisit", "inheritDocstrings",) | |||
| "wraparoundNVisit", "inheritDocstrings", "spectrographFromFiberId", "fiberHoleFromFiberId") | |||
There was a problem hiding this comment.
Shouldn't these come from pfs_utils? That would add a dependency, but as you pointed out, the objects returned from datamodel may not be functional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.