New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Contributing.md sample #245

Merged
merged 1 commit into from Aug 2, 2017

Conversation

Projects
None yet
3 participants
@mmattes
Contributor

mmattes commented Jul 29, 2017

Open for discussion

@miped

This comment has been minimized.

Show comment
Hide comment
@miped

miped Jul 30, 2017

Contributor

This is awesome!

Contributor

miped commented Jul 30, 2017

This is awesome!

@sbuttgereit

This comment has been minimized.

Show comment
Hide comment
@sbuttgereit

sbuttgereit Jul 31, 2017

Collaborator

I just read through it. I think it's an excellent start and unless there's objection, I think this should merged.

I do think that new features should likely start out as issues in the issue tracker; probably with a little template that proposes the change, is it an addition or a change to an existing feature etc. With a standard period (maybe a week to start with) to allow community comment. This could be done with a templated PR rather than issues (may be more appropriate)

Having said all that, I don't think too many PRs pulling things in odd directions is a problem right now, so even without setting any of that up, I think this is a good start.

If I don't hear anything to the contrary (and if it hasn't happened yet) I'll go ahead and do the merge on Tuesday evening (my time).

Many thanks for this @mmattes!

Collaborator

sbuttgereit commented Jul 31, 2017

I just read through it. I think it's an excellent start and unless there's objection, I think this should merged.

I do think that new features should likely start out as issues in the issue tracker; probably with a little template that proposes the change, is it an addition or a change to an existing feature etc. With a standard period (maybe a week to start with) to allow community comment. This could be done with a templated PR rather than issues (may be more appropriate)

Having said all that, I don't think too many PRs pulling things in odd directions is a problem right now, so even without setting any of that up, I think this is a good start.

If I don't hear anything to the contrary (and if it hasn't happened yet) I'll go ahead and do the merge on Tuesday evening (my time).

Many thanks for this @mmattes!

@sbuttgereit sbuttgereit merged commit 9c134c0 into SublimeGit:master Aug 2, 2017

@mmattes mmattes deleted the mmattes:Contribute.md branch Aug 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment