Fix regular expressions for GHCi to correctly parse multiline output. #87

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@sukhodolin
Contributor

sukhodolin commented Aug 3, 2013

Without re.DOTALL regexps will match anything except a newline.

Fix regular expressions for GHCi to correctly parse multiline output.
Without re.DOTALL regexps will match anything *except* a newline.
@sukhodolin

This comment has been minimized.

Show comment Hide comment
@sukhodolin

sukhodolin Aug 3, 2013

Contributor

Probably it'd be a good idea to remove newlines from extracted values as well. Though I don't know how reasonably long function types can be...

Contributor

sukhodolin commented Aug 3, 2013

Probably it'd be a good idea to remove newlines from extracted values as well. Though I don't know how reasonably long function types can be...

@sukhodolin

This comment has been minimized.

Show comment Hide comment
@sukhodolin

sukhodolin Nov 10, 2013

Contributor

Would someone take a look at this change please? I'm pretty sure that re.DOTALL was the original intent anyway, re.MULTILINE doesn't do the right thing.

Contributor

sukhodolin commented Nov 10, 2013

Would someone take a look at this change please? I'm pretty sure that re.DOTALL was the original intent anyway, re.MULTILINE doesn't do the right thing.

@nh2

This comment has been minimized.

Show comment Hide comment
@nh2

nh2 Nov 10, 2013

Member

Could you make a small example of a failing-vs-working behaviour that is fixed by this?

You probably have something that breaks for you without this. Thanks :)

Member

nh2 commented Nov 10, 2013

Could you make a small example of a failing-vs-working behaviour that is fixed by this?

You probably have something that breaks for you without this. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment