Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do I use this in windows #2

Closed
creationix opened this issue Jan 7, 2015 · 7 comments
Closed

How do I use this in windows #2

creationix opened this issue Jan 7, 2015 · 7 comments

Comments

@creationix
Copy link

I finally got luacheck installed on windows (no easy feat). With sublimelinter running in debug mode, I can see it's running luacheck against my code and outputting the proper warnings to the console, but the sublime UI seems to think there are no errors or warnings? Has this been tested in windows and if so, how do I get it to work?

capture

@groteworld
Copy link
Member

Thanks for this! The regex was not ready for a C:\ style file path and wasn't matching any errors. Change has been made and should be in Package Control soon.

Watch the Version value on https://packagecontrol.io/packages/SublimeLinter-luacheck and once it says version 1.0.3, it should update when you restart ST3

@creationix
Copy link
Author

Doesn't appear to be working. I've got it cloned locally, but I don't know
enough python regex to debug it. I'll see if I can figure it out.

On Wed, Jan 7, 2015 at 9:59 AM, Blake Grotewold notifications@github.com
wrote:

Closed #2
#2.


Reply to this email directly or view it on GitHub
#2 (comment)
.

@groteworld groteworld reopened this Jan 7, 2015
@groteworld
Copy link
Member

Really sorry about that, trying to make the changes from a computer that doesn't have luacheck so it was a well educated guess. Try replacing the linter.py regex r'^(c:)?(?P<filename>[^:]+):(?P<line>\d+):(?P<col>\d+): (?P<message>.*)$' with r'^(?P<filename>.+):(?P<line>\d+):(?P<col>\d+): (?P<message>.*)$' and see if that doesn't resolve your issue.

@creationix
Copy link
Author

yep, that does it!

@groteworld
Copy link
Member

Awesome, feel free to make a PR otherwise I'll do it

@creationix
Copy link
Author

I'll let you do it if that's fine.

On Wed, Jan 7, 2015 at 11:35 AM, Blake Grotewold notifications@github.com
wrote:

Awesome, feel free to make a PR otherwise I'll do it


Reply to this email directly or view it on GitHub
#2 (comment)
.

@groteworld
Copy link
Member

Thanks again, should go live soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants