New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiline highlight #100

Closed
pwntester opened this Issue Mar 26, 2014 · 4 comments

Comments

2 participants
@pwntester

pwntester commented Mar 26, 2014

It would be great to have multiline highlight by wrapping all the lines related with a single error in a single highlight that expands to several lines like in this picture:

http://www.sublimerge.com/Images/sublimerge-pro.png

New capture groups should be added to the linter regex to indicate the linenumber (already exists) and number of lines (default to 1)

@aparajita

This comment has been minimized.

Show comment
Hide comment
@aparajita

aparajita Mar 27, 2014

Contributor

Two problems:

  • To my knowledge, no linter provides enough information to do what you are suggesting. They give a line number and column at most.
  • Unless you are willing to implement it, there is basically zero chance of this ever happening.

Unless you can convince me otherwise, I'm going to close this.

Contributor

aparajita commented Mar 27, 2014

Two problems:

  • To my knowledge, no linter provides enough information to do what you are suggesting. They give a line number and column at most.
  • Unless you are willing to implement it, there is basically zero chance of this ever happening.

Unless you can convince me otherwise, I'm going to close this.

@pwntester

This comment has been minimized.

Show comment
Hide comment
@pwntester

pwntester Mar 27, 2014

Custom linters do it (at least mine :D) I will try to implement it and send a pull request.

pwntester commented Mar 27, 2014

Custom linters do it (at least mine :D) I will try to implement it and send a pull request.

@pwntester

This comment has been minimized.

Show comment
Hide comment
@pwntester

pwntester Mar 27, 2014

I sent a pull request implementing this new feature. Hope it gets into main!
Thanks!

pwntester commented Mar 27, 2014

I sent a pull request implementing this new feature. Hope it gets into main!
Thanks!

@aparajita

This comment has been minimized.

Show comment
Hide comment
@aparajita

aparajita May 17, 2014

Contributor

Merging with #101.

Contributor

aparajita commented May 17, 2014

Merging with #101.

@aparajita aparajita closed this May 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment