New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"toggle highlights" off by default #1323

Open
krishnaghatti opened this Issue Apr 17, 2018 · 8 comments

Comments

4 participants
@krishnaghatti

krishnaghatti commented Apr 17, 2018

Is there a way to keep the highlights toggle to off by default?
I have to go to the command pallet and choose the "toggle highlights" for each file opened.

screen shot 2018-04-18 at 1 42 09 am

@braver

This comment has been minimized.

Show comment
Hide comment
@braver

braver Apr 17, 2018

Member

Do you want to have them “off” permanently, or just by default and them switch them on when needed?

Member

braver commented Apr 17, 2018

Do you want to have them “off” permanently, or just by default and them switch them on when needed?

@krishnaghatti

This comment has been minimized.

Show comment
Hide comment
@krishnaghatti

krishnaghatti Apr 17, 2018

I want them to be off by default, but should be able to enable when required.

krishnaghatti commented Apr 17, 2018

I want them to be off by default, but should be able to enable when required.

@braver braver added the enhancement label Apr 18, 2018

@braver braver changed the title from disable "toggle highlights" to "toggle highlights" off by default Apr 18, 2018

@middlesister

This comment has been minimized.

Show comment
Hide comment
@middlesister

middlesister May 8, 2018

+1

It would be great if this could be a project/user specific setting.

middlesister commented May 8, 2018

+1

It would be great if this could be a project/user specific setting.

@kaste

This comment has been minimized.

Show comment
Hide comment
@kaste

kaste May 8, 2018

Contributor

I also would like to see/test that. (I wrote the current toggler here, and it just came naturally from the code and data model we had there. I don't think a global toggler is completely naive, trivial code. But then, the code changed since then anyways. 🤷‍♀️ )

Contributor

kaste commented May 8, 2018

I also would like to see/test that. (I wrote the current toggler here, and it just came naturally from the code and data model we had there. I don't think a global toggler is completely naive, trivial code. But then, the code changed since then anyways. 🤷‍♀️ )

@kaste

This comment has been minimized.

Show comment
Hide comment
@kaste

kaste May 10, 2018

Contributor

Okay, after looking at it it seems relatively trivial to add.

I cannot do a project wide setting bc we don't have such a layer (yet?). So it would be global switch. We also do not persist settings, so it would be a default after starting Sublime. Like highlights.on_after_start: true|false.

I also don't know if we need both, a toggler for views and a global toggler for the whole app. 🤷‍♂️

Contributor

kaste commented May 10, 2018

Okay, after looking at it it seems relatively trivial to add.

I cannot do a project wide setting bc we don't have such a layer (yet?). So it would be global switch. We also do not persist settings, so it would be a default after starting Sublime. Like highlights.on_after_start: true|false.

I also don't know if we need both, a toggler for views and a global toggler for the whole app. 🤷‍♂️

@kaste

This comment has been minimized.

Show comment
Hide comment
@kaste

kaste Jun 18, 2018

Contributor

Something very similar has been implemented as a plugin https://github.com/kaste/SublimeLinter-addon-filter

Look esp. for the on/off switch at the bottom. Install via Package Control; search for SublimeLinter-addon-filter

Contributor

kaste commented Jun 18, 2018

Something very similar has been implemented as a plugin https://github.com/kaste/SublimeLinter-addon-filter

Look esp. for the on/off switch at the bottom. Install via Package Control; search for SublimeLinter-addon-filter

@krishnaghatti

This comment has been minimized.

Show comment
Hide comment
@krishnaghatti

krishnaghatti Jun 30, 2018

@kaste Thank you for the update. I was using the plugin for a few days now. Just to clarify, the "off" part of the toggle will switch the linter off completely right?

krishnaghatti commented Jun 30, 2018

@kaste Thank you for the update. I was using the plugin for a few days now. Just to clarify, the "off" part of the toggle will switch the linter off completely right?

@kaste

This comment has been minimized.

Show comment
Hide comment
@kaste

kaste Jun 30, 2018

Contributor

The linters actually run in the background but don't produce any visual outcome when off. This is similar to the toggle highlights command and has the advantage of being very fast or immediate.

If you want to actually toggle linters, there is another plugin for that as well. Search for addon-toggler or something like that in Package Control.

Contributor

kaste commented Jun 30, 2018

The linters actually run in the background but don't produce any visual outcome when off. This is similar to the toggle highlights command and has the advantage of being very fast or immediate.

If you want to actually toggle linters, there is another plugin for that as well. Search for addon-toggler or something like that in Package Control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment