Upgraded package to Sublime Text 3 #25
Conversation
In sublime Text 3 calls to sublime methods are restricted during startup. Full path to sublime_lib must therefore only use system calls. Use path relative to AAA.py.
begin_edit/end_edit are restricted in Sublim Text 3. Use class derived from TextCommand to get hold of the edit object.
There was a problem hiding this comment.
This should be from unittest import mock because of the module namespace. Same in other test files.
|
In terms of replacing the Other than that, I actually changed a few things in #13. I am willing to assure ST3 compatability with that myself once it is merged (to not further increase the size of the PR) but I let @guillermooo decide on this. |
|
So what's up with getting an ST3 version up and running? This is an extremely useful package, I hate not having it. |
|
I'd really like #13 to be merged. Really, really. But I can also understand that guiller has quite a lot to do with reviewing 133 commits. So well, I'll think about an alternative solution. |
|
For reference, I did some porting of the post 0.5.0 master. Do note that I was just focusing on getting yaml conversion of a JSON language definition working, so it is by no means complete and/or tested. But it could probably serves as a basis for a TODO-list |
|
@JohnNilsson, thanks, I'm sure that helps. I will write code compatible with ST2 and ST3 so I can't really use your changes, but it will sure help as TODO. |
Made the necessary changes to make the package work for Sublime Text 3. Tried to make the impact of the changes as small as possible, only the absolute necessary to make it work in version 3 while ensuring compatibility with version 2. The following actions has been done:
The changes was tested on Sublime Text 2 (2.0.1 and 2.0.2) and Sublime Text 3 beta (build 3047).