Improved open rspec file #11

Merged
merged 3 commits into from Jun 24, 2012

Conversation

Projects
None yet
2 participants
Contributor

rexikan commented Jun 24, 2012

Here is a somewhat opinionated pull request that changes how OpenRSpecFile and RSpecCreateModule places the views inside the focus group. I hope it is considered anyway!

The idea is to use whatever focus group layout that the user has to place the views. For example, if you have a layout with two groups and the code to the left, then the OpenRspecFileCommand will open the spec to the right, and the other way around. If both files is open the command will toggle between them.

Benefits:

  • Doesn't touch the users group layout.
  • The user can have the code and spec in any order that he wants.
  • Only one keyboard shortcut is needed instead of four.
  • Works well with any layout. For example, if the user uses the grid layout, the code and spec will open in each column on the same row.

I also removed windows style line endings to make the package consequent in that regard.

Cheers!

@barneywilliams barneywilliams pushed a commit that referenced this pull request Jun 24, 2012

Greg Williams Merge pull request #11 from rexikan/improved_open_rspec_file
Improved open rspec file
e4eec33

@barneywilliams barneywilliams merged commit e4eec33 into SublimeText:master Jun 24, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment