Skip to content

Conversation

@FichteFoll
Copy link
Member

This is an alternative approach to #178, using it as an inspiration but going about it slightly differently.

I tried to isolate commits into reasonable chunks.

Things I did:

  • Update repository structure (rename st3 to src).
  • Add pyproject.toml file with dev dependencies & using uv for our toolchain.
  • Require Python 3.8, since 3.3 is finally being deprecated by ST.
  • Remove vendor and combat folders since they are not necessary in 3.8.

Things I did not do:

  • Ensure that tests can still be run with Unittesting.
  • Test anything besides uv build.
  • Reformat or add a formatter configuration.

@deathaxe
Copy link
Member

Require Python 3.8, since 3.3 is finally being deprecated by ST.

IMHO, we should first create a py33 compatible WHEEL release, targeting legacy ST3/4 builds, to totally get rid of legacy dependency releases without breaking unmaintained py33 packages on ST3/4 platform.

A 2nd step then would be to upgrade code base to a py38-only version.

requires-python = ">=3.8,<=3.9"

[build-system]
requires = ["hatchling>=1.20", "hatch-vcs>=0.4"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's wrong with flit?

@deathaxe
Copy link
Member

For python 3.8 it may be useful to disable annotation evaluation via from __future__ import annotations to save some CPU cycles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants