New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textbox highlight border cut off in 3129 #1678

Closed
Zooce opened this Issue Apr 21, 2017 · 4 comments

Comments

4 participants
@Zooce

Zooce commented Apr 21, 2017

Summary

The bottom of the highlight border seems to be cut off in the Command Palette and Find textboxes. I tried messing with line padding in the settings but it didn't change these textboxes.

(The color scheme I'm using is a custom one that I haven't uploaded to Package Control yet, but any theme works to reproduce this.)

sublime_text_2017-04-19_10-20-41
sublime_text_2017-04-19_10-20-19

Expected behavior

Both the text and its highlighting (including its borders) are shown completely in textboxes.

Actual behavior

Bottom highlight border is cut off.

Steps to reproduce

  1. Select a color scheme preferably with a highlight border color different from highlight background.
  2. Use the built in Adaptive UI theme (may also be an issue with other themes).
  3. Open either the Find panel or the Command Palette and type in some text and highlight it.
  4. If you opened the Find panel, resize the panel downward to its smallest size.
  5. Notice the highlight border is cut off.

Environment

  • Operating system and version:
    • Windows 7 x64
  • Sublime Text:
    • Dev 3129
@FichteFoll

This comment has been minimized.

Show comment
Hide comment
@FichteFoll

FichteFoll Apr 21, 2017

Member

Have you set line_padding_top or line_padding_bottom in your preferences? I can only reproduce this with values >=3 for both.

Member

FichteFoll commented Apr 21, 2017

Have you set line_padding_top or line_padding_bottom in your preferences? I can only reproduce this with values >=3 for both.

@deathaxe

This comment has been minimized.

Show comment
Hide comment
@deathaxe

deathaxe Apr 22, 2017

I use line_padding_... = 5 on Windows 10 and can't reproduce it with ST 3130.

deathaxe commented Apr 22, 2017

I use line_padding_... = 5 on Windows 10 and can't reproduce it with ST 3130.

@Zooce

This comment has been minimized.

Show comment
Hide comment
@Zooce

Zooce Apr 22, 2017

Both line padding top and bottom are set to 3 in the screenshots above. More than 3 is too much for me. However, I tried messing with line padding - setting them to ranges between 0 and 5 and it did not fix the issue.

I've also tried this on my Mac, with the same results with Dev 3131.

Zooce commented Apr 22, 2017

Both line padding top and bottom are set to 3 in the screenshots above. More than 3 is too much for me. However, I tried messing with line padding - setting them to ranges between 0 and 5 and it did not fix the issue.

I've also tried this on my Mac, with the same results with Dev 3131.

@wbond

This comment has been minimized.

Show comment
Hide comment
@wbond

wbond May 26, 2017

Member

This should be fixed in build 3132

Member

wbond commented May 26, 2017

This should be fixed in build 3132

@wbond wbond closed this May 26, 2017

@wbond wbond added the R: fixed label May 26, 2017

@wbond wbond added this to the Build 3132 milestone May 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment