New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow students to pin threads #1973

Merged
merged 4 commits into from May 23, 2018

Conversation

Projects
None yet
4 participants
@scopeInfinity
Copy link
Member

scopeInfinity commented May 18, 2018

Issue : #1677

@scopeInfinity scopeInfinity requested a review from andrewaikens87 May 18, 2018

@bmcutler bmcutler requested a review from jchulton May 21, 2018

@jchulton

This comment has been minimized.

Copy link
Contributor

jchulton commented May 21, 2018

One potential issue is that pinned announcements are not ordered higher than non-pinned announcements. I believe this was the desired order that was discussed at Friday's meeting, please respond if it isn't.
pinnedscreenshot

@jchulton
Copy link
Contributor

jchulton left a comment

No visual problems with the code (no weird indenting or spacing or anything) but there is the potential bug discussed above.

@scopeInfinity

This comment has been minimized.

Copy link
Member Author

scopeInfinity commented May 22, 2018

Thanks @jchulton
The order of the threads should be in the order as mentioned by you. Fixed it.

@bmcutler bmcutler merged commit e3a9f9b into master May 23, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@bmcutler bmcutler deleted the forum_pin_thread branch May 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment