New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forum Categories having colors and edit category features #2135

Merged
merged 49 commits into from Jun 18, 2018

Conversation

Projects
None yet
5 participants
@scopeInfinity
Copy link
Member

scopeInfinity commented Jun 11, 2018

Issue: #2094 (Forum: color coded & instructor ordered tags)

To be merged after PR Forum Edit Categories (Reordering) #2126, need to change Base Branch of PR before merging.

Tasks

  • Categories with color tags
  • Modify color tags
  • Edit Category names
  • After adding category, it should be added in cat-buttons
  • Remove Category
  • Edit Thread Title
  • Allow Category of existing threads to be modified
  • Dynamically refreshing categories buttons on Create Thread page(for implemented features)
  • Instructor/full access ta should be able to view deleted threads

scopeInfinity and others added some commits Jun 4, 2018

@scopeInfinity scopeInfinity requested a review from andrewaikens87 Jun 11, 2018

@saxocellphone saxocellphone self-requested a review Jun 14, 2018

@scopeInfinity scopeInfinity changed the base branch from forum_multiple_categories to master Jun 14, 2018

scopeInfinity and others added some commits Jun 14, 2018

@saxocellphone

This comment has been minimized.

Copy link
Contributor

saxocellphone commented Jun 15, 2018

I'm getting a JS error data.trim is not a function in server.js:1420:9 when trying to create a thread as a student.
capture

However, the instructor's side works fine
capture2

@saxocellphone

This comment has been minimized.

Copy link
Contributor

saxocellphone commented Jun 15, 2018

Also I think it will be nice if the newly added categories show up on the list immediately after being added, instead of closing and reopening

@saxocellphone
Copy link
Contributor

saxocellphone left a comment

See above

@@ -515,6 +515,8 @@ CREATE TABLE "thread_categories" (
CREATE TABLE "categories_list" (
"category_id" serial NOT NULL,
"category_desc" varchar NOT NULL,
"rank" int,
"color" varchar DEFAULT '#000080',

This comment has been minimized.

@MasterOdin

MasterOdin Jun 15, 2018

Member

can color be null?

This comment has been minimized.

@scopeInfinity

scopeInfinity Jun 17, 2018

Author Member

No, it can't be NULL. Thankyou!

@andrewaikens87

This comment has been minimized.

Copy link
Member

andrewaikens87 commented Jun 15, 2018

Students view isn't populating (visibly) with any categories to select it seems. Also noticed that you can create a category with the same name as another with difference in capitalization (not related to the changes in this PR I believe). Take a look at the screenshot below. I don't think we would want to allow this.

Instructor:
instructor

Student:
aphacker

@scopeInfinity scopeInfinity changed the title Forum Categories having colors and edit category features [WIP] Forum Categories having colors and edit category features Jun 15, 2018

scopeInfinity added some commits Jun 16, 2018

@scopeInfinity scopeInfinity force-pushed the forum_edit_categories_colorAndText branch from e759d6c to f149c6f Jun 17, 2018

@scopeInfinity

This comment has been minimized.

Copy link
Member Author

scopeInfinity commented Jun 17, 2018

@andrewaikens87 @saxocellphone Yah, it wasn't visibly populating categories for students, indeed a big bug.. Thankyou!
Fixed it.

@scopeInfinity scopeInfinity changed the title [WIP] Forum Categories having colors and edit category features Forum Categories having colors and edit category features Jun 18, 2018

@bmcutler bmcutler merged commit 2b0004d into master Jun 18, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bmcutler bmcutler deleted the forum_edit_categories_colorAndText branch Jun 18, 2018

@MasterOdin

This comment has been minimized.

Copy link
Member

MasterOdin commented Jun 18, 2018

Are we fine with this using the update_database.py or should we add a migration for this?

@bmcutler

This comment has been minimized.

Copy link
Contributor

bmcutler commented Jun 18, 2018

Shoot, I forgot to check for database changes.
No, we want to undo the edits to update_database and make it a migration.
Can you take care of that? Just make a new PR with the edits
(or we could revert...)

@MasterOdin

This comment has been minimized.

Copy link
Member

MasterOdin commented Jun 18, 2018

I'll make a new PR.

bmcutler added a commit that referenced this pull request Jun 19, 2018

[BUGFIX] DB migration for PR #2135 forum category colors (#2199)
PR #2135 mistakenly edited update_database.py (deprecated after early June 2018)
Instead these changes are placed in a database migration script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment