Forum Categories having colors and edit category features #2135

scopeInfinity · Jun 11, 2018

Issue: #2094 (Forum: color coded & instructor ordered tags)

To be merged after PR Forum Edit Categories (Reordering) #2126, need to change Base Branch of PR before merging.

Tasks

Categories with color tags
Modify color tags
Edit Category names
After adding category, it should be added in cat-buttons
Remove Category
~~Edit Thread Title~~
~~Allow Category of existing threads to be modified~~
Dynamically refreshing categories buttons on Create Thread page(for implemented features)
~~Instructor/full access ta should be able to view deleted threads~~

saxocellphone · Jun 15, 2018

I'm getting a JS error data.trim is not a function in server.js:1420:9 when trying to create a thread as a student.

However, the instructor's side works fine

saxocellphone · Jun 15, 2018

Also I think it will be nice if the newly added categories show up on the list immediately after being added, instead of closing and reopening

saxocellphone · Jun 15, 2018

saxocellphone requested changes Jun 15, 2018

View changes

See above

MasterOdin · Jun 15, 2018

MasterOdin reviewed Jun 15, 2018

View changes

MasterOdin · Jun 15, 2018

migration/data/course_tables.sql

@@ -515,6 +515,8 @@ CREATE TABLE "thread_categories" (
 CREATE TABLE "categories_list" (
 	"category_id" serial NOT NULL,
 	"category_desc" varchar NOT NULL,
+	"rank" int,
+	"color" varchar DEFAULT '#000080',


can color be null?

No, it can't be NULL. Thankyou!

andrewaikens87 · Jun 15, 2018

Students view isn't populating (visibly) with any categories to select it seems. Also noticed that you can create a category with the same name as another with difference in capitalization (not related to the changes in this PR I believe). Take a look at the screenshot below. I don't think we would want to allow this.

Instructor:

Student:

scopeInfinity · Jun 17, 2018

@andrewaikens87 @saxocellphone Yah, it wasn't visibly populating categories for students, indeed a big bug.. Thankyou!
Fixed it.

saxocellphone · Jun 18, 2018

saxocellphone approved these changes Jun 18, 2018

View changes

MasterOdin · Jun 18, 2018

Are we fine with this using the update_database.py or should we add a migration for this?

bmcutler · Jun 18, 2018

Shoot, I forgot to check for database changes.
No, we want to undo the edits to update_database and make it a migration.
Can you take care of that? Just make a new PR with the edits
(or we could revert...)

MasterOdin · Jun 18, 2018

I'll make a new PR.

scopeInfinity requested a review from andrewaikens87 Jun 11, 2018

Forum, Delete Category

Loading status checks…

8008823

Inline Add Category field in popup

Loading status checks…

57475fa

saxocellphone self-requested a review Jun 14, 2018

scopeInfinity changed the base branch from forum_multiple_categories to master Jun 14, 2018

scopeInfinity changed the title ~~Forum Categories having colors and edit category features~~ [WIP] Forum Categories having colors and edit category features Jun 15, 2018

scopeInfinity force-pushed the forum_edit_categories_colorAndText branch from e759d6c to f149c6f Jun 17, 2018

scopeInfinity changed the title ~~[WIP] Forum Categories having colors and edit category features~~ Forum Categories having colors and edit category features Jun 18, 2018

Merge branch 'master' into forum_edit_categories_colorAndText

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

1e92a58

bmcutler merged commit 2b0004d into master Jun 18, 2018
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

continuous-integration/travis-ci/push The Travis CI build passed
Details

bmcutler deleted the forum_edit_categories_colorAndText branch Jun 18, 2018

bmcutler referenced this pull request Jun 19, 2018
Merged
[BUGFIX] DB migration for PR #2135 forum category colors #2199

Submitty/Submitty

Forum Categories having colors and edit category features #2135

Forum Categories having colors and edit category features #2135

scopeInfinity commented Jun 11, 2018 •

edited

scopeInfinity and others added some commits Jun 4, 2018

scopeInfinity requested a review from andrewaikens87 Jun 11, 2018

saxocellphone self-requested a review Jun 14, 2018

scopeInfinity changed the base branch from forum_multiple_categories to master Jun 14, 2018

scopeInfinity and others added some commits Jun 14, 2018

This comment has been minimized.

saxocellphone commented Jun 15, 2018 •

edited

This comment has been minimized.

saxocellphone commented Jun 15, 2018

saxocellphone requested changes Jun 15, 2018

View changes

saxocellphone left a comment

MasterOdin reviewed Jun 15, 2018

View changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

andrewaikens87 commented Jun 15, 2018 •

edited

scopeInfinity changed the title Forum Categories having colors and edit category features [WIP] Forum Categories having colors and edit category features Jun 15, 2018

scopeInfinity added some commits Jun 16, 2018

scopeInfinity force-pushed the forum_edit_categories_colorAndText branch from `e759d6c` to `f149c6f` Jun 17, 2018

This comment has been minimized.

scopeInfinity commented Jun 17, 2018 •

edited

saxocellphone approved these changes Jun 18, 2018

View changes

scopeInfinity changed the title [WIP] Forum Categories having colors and edit category features Forum Categories having colors and edit category features Jun 18, 2018

bmcutler merged commit `2b0004d` into master Jun 18, 2018
2 checks passed

2 checks passed

bmcutler deleted the forum_edit_categories_colorAndText branch Jun 18, 2018

This comment has been minimized.

MasterOdin commented Jun 18, 2018

This comment has been minimized.

bmcutler commented Jun 18, 2018

This comment has been minimized.

MasterOdin commented Jun 18, 2018

bmcutler referenced this pull request Jun 19, 2018

[BUGFIX] DB migration for PR #2135 forum category colors #2199

bmcutler added a commit that referenced this pull request Jun 19, 2018

Submitty/Submitty

Join GitHub today

Forum Categories having colors and edit category features #2135

Conversation

scopeInfinity commented Jun 11, 2018 • edited

scopeInfinity and others added some commits Jun 4, 2018

scopeInfinity requested a review from andrewaikens87 Jun 11, 2018

saxocellphone self-requested a review Jun 14, 2018

scopeInfinity changed the base branch from forum_multiple_categories to master Jun 14, 2018

scopeInfinity and others added some commits Jun 14, 2018

This comment has been minimized.

saxocellphone commented Jun 15, 2018 • edited

This comment has been minimized.

saxocellphone commented Jun 15, 2018

saxocellphone requested changes Jun 15, 2018 View changes

saxocellphone left a comment

MasterOdin reviewed Jun 15, 2018 View changes

This comment has been minimized.

MasterOdin Jun 15, 2018 • edited

This comment has been minimized.

scopeInfinity Jun 17, 2018

This comment has been minimized.

andrewaikens87 commented Jun 15, 2018 • edited

scopeInfinity changed the title Forum Categories having colors and edit category features [WIP] Forum Categories having colors and edit category features Jun 15, 2018

scopeInfinity added some commits Jun 16, 2018

scopeInfinity force-pushed the forum_edit_categories_colorAndText branch from e759d6c to f149c6f Jun 17, 2018

This comment has been minimized.

scopeInfinity commented Jun 17, 2018 • edited

saxocellphone approved these changes Jun 18, 2018 View changes

scopeInfinity changed the title [WIP] Forum Categories having colors and edit category features Forum Categories having colors and edit category features Jun 18, 2018

Hide details View details bmcutler merged commit 2b0004d into master Jun 18, 2018 2 checks passed

2 checks passed

bmcutler deleted the forum_edit_categories_colorAndText branch Jun 18, 2018

This comment has been minimized.

MasterOdin commented Jun 18, 2018

This comment has been minimized.

bmcutler commented Jun 18, 2018

This comment has been minimized.

MasterOdin commented Jun 18, 2018

bmcutler referenced this pull request Jun 19, 2018

[BUGFIX] DB migration for PR #2135 forum category colors #2199

bmcutler added a commit that referenced this pull request Jun 19, 2018

scopeInfinity commented Jun 11, 2018 •

edited

saxocellphone commented Jun 15, 2018 •

edited

saxocellphone requested changes Jun 15, 2018

View changes

MasterOdin reviewed Jun 15, 2018

View changes

MasterOdin Jun 15, 2018 •

edited

andrewaikens87 commented Jun 15, 2018 •

edited

scopeInfinity force-pushed the forum_edit_categories_colorAndText branch from `e759d6c` to `f149c6f` Jun 17, 2018

scopeInfinity commented Jun 17, 2018 •

edited

saxocellphone approved these changes Jun 18, 2018

View changes

bmcutler merged commit `2b0004d` into master Jun 18, 2018
2 checks passed