New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forum Edit Thread #2150

Merged
merged 15 commits into from Jun 20, 2018

Conversation

Projects
None yet
4 participants
@scopeInfinity
Copy link
Member

scopeInfinity commented Jun 13, 2018

Issue: #1950

Task(s)

  • Shared template for edit post/thread and create new thread
  • Edit thread title in the discussion forum(Edit option of first post)
  • Edit Anon status of post
  • Edit Categories of Thread

scopeInfinity added some commits Jun 13, 2018

@scopeInfinity scopeInfinity requested a review from andrewaikens87 Jun 13, 2018

@bmcutler bmcutler requested a review from ropern123 Jun 13, 2018

@ropern123
Copy link
Contributor

ropern123 left a comment

It seems to work well!

Two possible issues:

  • You can't edit both the title and the post content at the same time (the alerts saying changes won't be saved are nice, but in my opinion updating both simultaneously is preferable).
  • In the meeting, we discussed having the form to edit the post share code with the form to create the post, but they seem to be somewhat different in formatting.
@andrewaikens87

This comment has been minimized.

Copy link
Member

andrewaikens87 commented Jun 15, 2018

I agree with @ropern123, we should be able to edit the thread and the post at the same time. On the note about limiting duplicate code @scopeInfinity we can discuss on slack.

@scopeInfinity scopeInfinity changed the title Forum Edit Thread [WIP] Forum Edit Thread Jun 15, 2018

@scopeInfinity scopeInfinity force-pushed the forum_thread_edit branch from 768a553 to a318f89 Jun 18, 2018

@scopeInfinity scopeInfinity changed the title [WIP] Forum Edit Thread Forum Edit Thread Jun 18, 2018

@scopeInfinity

This comment has been minimized.

Copy link
Member Author

scopeInfinity commented Jun 18, 2018

@ropern123 @andrewaikens87 Thanks for the review.
Now we are using common twig template while creating thread and editing post/thead.
And it submits thread and post updation as single request to backend.

@bmcutler bmcutler merged commit c40c604 into master Jun 20, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@bmcutler bmcutler deleted the forum_thread_edit branch Jun 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment