New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forum, Handle Dangling Posts on Creation #2229

Merged
merged 3 commits into from Jun 22, 2018

Conversation

Projects
None yet
5 participants
@scopeInfinity
Copy link
Member

scopeInfinity commented Jun 21, 2018

Closes : #2227 (Replying to Deleted Forum Posts)

@@ -346,6 +346,9 @@ public function publishPost(){
} else if(!$this->core->getQueries()->existsThread($thread_id)) {
$this->core->addErrorMessage("There was an error submitting your post. Thread doesn't exists.");
$this->core->redirect($this->core->buildUrl(array('component' => 'forum', 'page' => 'view_thread')));
} else if(!$this->core->getQueries()->existsPost($thread_id, $parent_id)) {
$this->core->addErrorMessage("There was an error submitting your post. Parent post doesn't exists in given thread.");

This comment has been minimized.

@MasterOdin

MasterOdin Jun 21, 2018

Member

"Parent post doesn't exist in given thread"

This comment has been minimized.

@ropern123

ropern123 Jun 21, 2018

Contributor

Same for error message 2 lines above: exists should be exist

@ropern123
Copy link
Contributor

ropern123 left a comment

Prevents post publishing.

@andrewaikens87
Copy link
Member

andrewaikens87 left a comment

Looks good, just need to make the changes requested in the comments above.

scopeInfinity and others added some commits Jun 22, 2018

@bmcutler bmcutler merged commit eb58a5c into master Jun 22, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@bmcutler bmcutler deleted the forum_thread_post_dangling branch Jun 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment