New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forum: Undelete posts/thread #2248

Merged
merged 9 commits into from Jun 28, 2018

Conversation

Projects
None yet
3 participants
@scopeInfinity
Copy link
Member

scopeInfinity commented Jun 25, 2018

Closes #2247

@scopeInfinity scopeInfinity requested a review from andrewaikens87 Jun 25, 2018

scopeInfinity and others added some commits Jun 25, 2018

@andrewaikens87
Copy link
Member

andrewaikens87 left a comment

Once small changes are fixed below this should be good.

$type = "thread";
} else {
$type = "post";
}
$this->core->getOutput()->renderJson(array('type' => $type));
} else if($modifyType == 2) { //undelete post or thread

This comment has been minimized.

@andrewaikens87

andrewaikens87 Jun 28, 2018

Member

Lets add some comments above the method declaration, similar to your comments for setDeletePostStatus. It might be worth breaking this function up in the future.

} else {
$return .= <<<HTML
<a class="post_button" style="bottom: 1px;position:relative; display:inline-block; float:right;" onClick="deletePostToggle(true, {$post['thread_id']}, {$post['id']}, '{$post['author_user_id']}', '{$function_date($date,'n/j g:i A')}' )" title="Remove post"><i class="fa fa-trash" aria-hidden="true"></i></a>
HTML;

This comment has been minimized.

@andrewaikens87

andrewaikens87 Jun 28, 2018

Member

These blocks are almost identical please try to consolidate

@scopeInfinity

This comment has been minimized.

Copy link
Member Author

scopeInfinity commented Jun 28, 2018

Pushed some changes(not yet tested)...

bmcutler added some commits Jun 28, 2018

@bmcutler bmcutler merged commit 1d55494 into master Jun 28, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@bmcutler bmcutler deleted the forum_undelete_post branch Jun 29, 2018

KevinMackenzie added a commit that referenced this pull request Jun 29, 2018

Forum: Undelete posts/thread (#2248)
* Undelete thread/post

* Fixed Typo

* Removed duplicate code for two buttons + Documentation

* Better color for background

* Small fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment