New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forum: Allow original author to edit post/thread #2301

Merged
merged 32 commits into from Jul 16, 2018

Conversation

Projects
None yet
4 participants
@scopeInfinity
Copy link
Member

scopeInfinity commented Jun 29, 2018

Closes: #2246

  • Maintain history of edits
  • Allow author and instructor to edit the post
  • Markdown support(Code and URL block) in post history box
  • Show created timestamp and last edited timestamp for the post.

@scopeInfinity scopeInfinity requested a review from andrewaikens87 Jul 6, 2018

@scopeInfinity scopeInfinity changed the title [WIP] Forum: Allow original author to edit post/thread Forum: Allow original author to edit post/thread Jul 6, 2018

@andrewaikens87

This comment has been minimized.

Copy link
Member

andrewaikens87 commented Jul 7, 2018

  • I really like the edit history popup, it's easy to read and see who posted the edits. On this popup though, the dates/times need to be formatted similar to how they are on the forum posts. Also it would be nice if we could have the same functionality of as we do on the forum posts in terms of how we display names (rather than just user ids).
  • I noticed that if a TA/Instructor edits a post, it changes the author of that post to be the TA/Instructor who edited it. We want to preserve the original author of the post, but it might be nice to also display the person who last edited the post.
    Also when you mention that it has Markdown support, in my tests it seems like the edit history isn't displaying code blocks or links similar to that in the forum.
@andrewaikens87
Copy link
Member

andrewaikens87 left a comment

I made some suggestions above

@scopeInfinity

This comment has been minimized.

Copy link
Member Author

scopeInfinity commented Jul 9, 2018

Thankyou @andrewaikens87
PR now preserves the original author and start pushing posts in forum_posts_history only after an edit is made.
And history popup posts are now similar to the actual post in terms of display name and time formatting.

@ropern123
Copy link
Contributor

ropern123 left a comment

  • If one edits a post but presses cancel, the popup for changing the page in spite of changes pops up (feels like it shouldn't since you chose to cancel the changes?)
  • Making a post with one line of code leads to the code being difficult to see in the edit history (especially if using the scroll bar arrows)
  • Also, not sure if this is just on my machine, but the forum stats button is not working

scopeInfinity added some commits Jul 9, 2018

@scopeInfinity

This comment has been minimized.

Copy link
Member Author

scopeInfinity commented Jul 10, 2018

@ropern123 Thank you for pointing out. I have fixed first and third point.
I will be working on second one.

bmcutler and others added some commits Jul 10, 2018

scopeInfinity added some commits Jul 11, 2018

@scopeInfinity scopeInfinity referenced this pull request Jul 11, 2018

Merged

Forum Thread Status #2341

bmcutler and others added some commits Jul 12, 2018

@andrewaikens87

This comment has been minimized.

Copy link
Member

andrewaikens87 commented Jul 14, 2018

Couple things and it should be good:

  • The user info in the view history popup has Firstname Firstname in the example below Joe's lastname is supposed to be Student
    firstname
  • This is optional but in the view history it might be nice to have the gold border around edits by TA/Instructors
@scopeInfinity

This comment has been minimized.

Copy link
Member Author

scopeInfinity commented Jul 15, 2018

Thanks, @andrewaikens87
I missed that. Fixed it.

scopeInfinity and others added some commits Jul 16, 2018

Update 20180705150129_forum_posts_history.py
extra table doesn't cause problem

@bmcutler bmcutler merged commit 03f2888 into master Jul 16, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@bmcutler bmcutler deleted the forum_edit_originalauthor branch Jul 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment