New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forum Thread: Show author email address #2527

Merged
merged 4 commits into from Jul 25, 2018

Conversation

Projects
None yet
3 participants
@scopeInfinity
Copy link
Member

scopeInfinity commented Jul 23, 2018

Closes: #2493
Allows instructors & full access graders to view email address of thread author.

@scopeInfinity scopeInfinity requested a review from andrewaikens87 Jul 23, 2018

@andrewaikens87
Copy link
Member

andrewaikens87 left a comment

Looks good, just small tweaks.

$first_name = htmlentities(trim($full_name["first_name"]), ENT_QUOTES | ENT_HTML5, 'UTF-8');
$last_name = htmlentities(trim($full_name["last_name"]), ENT_QUOTES | ENT_HTML5, 'UTF-8');
$user_info = $this->core->getQueries()->getDisplayUserInfoFromUserId($post["author_user_id"]);
$author_email = $user_info['user_email'];

This comment has been minimized.

@andrewaikens87

andrewaikens87 Jul 24, 2018

Member

Let's encode the string just to be safe.

@@ -2187,6 +2187,7 @@ public function getDisplayUserNameFromUserId($user_id){
$ar = array();
$ar["first_name"] = $name;
$ar["last_name"] = $last_name;
$ar["user_email"] = $name_rows["user_email"];;

This comment has been minimized.

@andrewaikens87

andrewaikens87 Jul 24, 2018

Member

Seems to be 2 semicolons here

@scopeInfinity

This comment has been minimized.

Copy link
Member Author

scopeInfinity commented Jul 24, 2018

andrewaikens87 added some commits Jul 24, 2018

@andrewaikens87
Copy link
Member

andrewaikens87 left a comment

Looks good

@bmcutler bmcutler merged commit c8ce0bc into master Jul 25, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bmcutler bmcutler deleted the forum_thread_authoremail branch Jul 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment