New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forum: Show Merged threads #2599

Merged
merged 10 commits into from Aug 3, 2018

Conversation

Projects
None yet
3 participants
@scopeInfinity
Copy link
Member

scopeInfinity commented Jul 29, 2018

Issue: #2492

Currently, the merged thread have "fa fa-link" icon in the threads list, it can be changed(suggestions?)

@scopeInfinity scopeInfinity requested a review from andrewaikens87 Jul 29, 2018

@@ -1589,6 +1589,11 @@ function alterShowDeletedStatus(newStatus) {
location.reload();
}

function alterShowMergeThreadStatus(newStatus) {
document.cookie = "show_merged_thread=" + newStatus + "; path=/;";

This comment has been minimized.

@andrewaikens87

andrewaikens87 Jul 31, 2018

Member

This should be course specific

@andrewaikens87
Copy link
Member

andrewaikens87 left a comment

Error after merge:
errored

Forum with no threads warnings:
emptyforum

if($option == "alpha"){
$posts = $this->core->getQueries()->getPostsForThread($current_user, $thread_id, $show_deleted, 'alpha');
} else {
$posts = $this->core->getQueries()->getPostsForThread($current_user, $thread_id, $show_deleted, 'tree');
}
if(empty($posts)){
$this->core->addErrorMessage("No posts found for given threads.");

This comment has been minimized.

@andrewaikens87

andrewaikens87 Aug 2, 2018

Member

Let's make this: "No posts found for selected thread."

@andrewaikens87

This comment has been minimized.

Copy link
Member

andrewaikens87 commented Aug 2, 2018

For the child thread, when displaying merged threads, the resolve state is shown but there is no way to resolve it. We should either not display the resolve state for the child thread when displaying merged threads or give the ability to the creator of the child thread to resolve their original thread.

test_thread

andrewaikens87 and others added some commits Aug 2, 2018

@bmcutler bmcutler merged commit 843849c into master Aug 3, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@bmcutler bmcutler deleted the forum_show_merged_threads branch Aug 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment