New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forum: Bidirectional scroll for thread list #2654

Merged
merged 18 commits into from Aug 16, 2018

Conversation

Projects
None yet
3 participants
@scopeInfinity
Copy link
Member

scopeInfinity commented Aug 3, 2018

Issue: #2596

  • Thread list scroll as the bi-directional infinite scroll.
  • Remember the scroll position OR jump to thread page containing current thread.
  • Move to Top button, not same as scrolling up (Announcements are at top)

@scopeInfinity scopeInfinity changed the title Forum: Remember position of scroll in thread list [WIP] Forum: Remember position of scroll in thread list Aug 3, 2018

@scopeInfinity scopeInfinity requested a review from andrewaikens87 Aug 5, 2018

@scopeInfinity scopeInfinity changed the title [WIP] Forum: Remember position of scroll in thread list Forum: Bidirectional scroll for thread list Aug 5, 2018

@andrewaikens87
Copy link
Member

andrewaikens87 left a comment

If (from student view) a thread is self-pinned it seems to lockup/break the dynamic scroll bar.

scopeInfinity and others added some commits Aug 6, 2018

@andrewaikens87

This comment has been minimized.

Copy link
Member

andrewaikens87 commented Aug 8, 2018

It seems like I am able to scroll up when I shouldn't be. To recreate, I scrolled down a bit and then scrolled up and continued to do so, it will continue to load the same block of threads over and over. Also my browser is set to 100% zoom (default) and the go to bottom button is way below where it should be. I must set the zoom to 150% to have it in the correct location.

bad

scopeInfinity and others added some commits Aug 8, 2018

@andrewaikens87
Copy link
Member

andrewaikens87 left a comment

Works as intended. Couple of suggestions: When scrolling up/down it can load multiple blocks rapidly, we might want to add a short delay when loading thread blocks. Another thing is the move to top and bottom buttons are currently sitting above the scroll bar, I am not sure if this is the final location that we want to place them. It might be better to place them on the left or right side of the thread list.

@bmcutler bmcutler merged commit 103309a into master Aug 16, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bmcutler bmcutler deleted the forum_scrollfix_paging branch Aug 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment