Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix]Aligning select color tag in 'Edit categories' #3463

Merged
merged 6 commits into from May 2, 2019

Conversation

weastel
Copy link
Contributor

@weastel weastel commented Mar 24, 2019

Fixes #3461
ezgif com-video-to-gif(2)

@weastel weastel changed the title [Bugfix]Aligning select color select in 'Edit categories' [Bugfix]Aligning select color tag in 'Edit categories' Mar 24, 2019
Copy link
Contributor

@andrewaikens87 andrewaikens87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. Please take a look at my comments below.

@@ -1270,6 +1270,7 @@ div.full_height {
border-radius: 0.3em;
margin: 0.3em 0.1em 0.3em 0.1em;
padding: 0.2em;
width:400px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we simply just modify the width on line 1263? Also I didn't experience this issue, are you zoomed in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue is only visible on firefox browser

@weastel
Copy link
Contributor Author

weastel commented Mar 24, 2019

@andrewaikens87 Can you please review it again?

@weastel
Copy link
Contributor Author

weastel commented Apr 25, 2019

@andrewaikens87 Is this okay?

@shwehtom89 shwehtom89 self-requested a review May 2, 2019 18:46
Copy link
Contributor

@shwehtom89 shwehtom89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drumilpatel2000 Code looks good and does what is describes. I am going to approve of this PR and if you get the chance could you take a look at #3631.

@bmcutler bmcutler merged commit 7f93122 into Submitty:master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Misalignment on editing categories
4 participants