Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Improve student validation for late days allowed #3886

Merged
merged 2 commits into from Jun 21, 2019

Conversation

weastel
Copy link
Contributor

@weastel weastel commented Jun 19, 2019

Please check if the PR fulfills these requirements:

What is the current behavior?

Fixes #3449

What is the new behavior?

Invalid Student ID Error is shown when student selected is not from the course.

Other information?

  1. Go to Late Days Allowed in Development
  2. Try to insert late days for ta2(ta2 is not in Development but in Sample)
  3. Invalid Student ID error should be shown

@weastel weastel changed the title Check user check from submitty database to specific course database [BUGFIX] Improve student validation for late days allowed Jun 19, 2019
Copy link
Member

@bmcutler bmcutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This boolean name seems inverse to me.
IsUserInCourse should be true if the query is non-empty.

@weastel weastel requested a review from bmcutler June 20, 2019 21:38
@bmcutler bmcutler merged commit 2f041cb into master Jun 21, 2019
@bmcutler bmcutler deleted the improve_student_id_validation branch June 21, 2019 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve student ID validation in "Late Days Allowed"
2 participants