New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cylinder equipment tooltips with gas volume #155

Merged
merged 1 commit into from Jan 12, 2017

Conversation

Projects
None yet
4 participants
@torvalds
Collaborator

torvalds commented Jan 11, 2017

This adds tooltips for the equipment tab for each cylinder, showing the
amount of gas used.

When you mouse over the size and working pressure fields, the tooltip will
show the amount of gas used (along with start and end gas volumes). And
when you mouse over the start and end pressures, it will show the start
and end gas volumes, and the Z factor used.

I started doing this because of the gas volume questions in the last day
or two (and a few from a few weeks ago). When even Robert Helling starts
wondering about the effects of compressibility on the SAC calculation, our
numbers are clearly too opaque.

With these tooltips, at least you can see what went into the used gas
calculations, instead of having to add debugging options to print out Z
factors.

[ This patch also adds a "rint()" to get the rounding right in the
gas_volume() function. Although rounding to the nearst milliliter
really doesn't matter, it's the right thing to do after doing FP
calculations ;^]

Signed-off-by: Linus Torvalds torvalds@linux-foundation.org

Add cylinder equipment tooltips with gas volume
This adds tooltips for the equipment tab for each cylinder, showing the
amount of gas used.

When you mouse over the size and working pressure fields, the tooltip will
show the amount of gas used (along with start and end gas volumes). And
when you mouse over the start and end pressures, it will show the start
and end gas volumes, and the Z factor used.

I started doing this because of the gas volume questions in the last day
or two (and a few from a few weeks ago). When even Robert Helling starts
wondering about the effects of compressibility on the SAC calculation, our
numbers are clearly too opaque.

With these tooltips, at least you can see what went into the used gas
calculations, instead of having to add debugging options to print out Z
factors.

[ This patch also adds a "rint()" to get the rounding right in the
  gas_volume() function.  Although rounding to the nearst milliliter
  really doesn't matter, it's the right thing to do after doing FP
  calculations ;^]

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

@Subsurface-divelog Subsurface-divelog merged commit 638e7fb into Subsurface-divelog:master Jan 12, 2017

@SharksevenRo

This comment has been minimized.

Show comment
Hide comment
@SharksevenRo

SharksevenRo commented Oct 13, 2017

cool

@sriharshakappala

This comment has been minimized.

Show comment
Hide comment
@sriharshakappala

sriharshakappala commented Oct 19, 2017

This pull request is featured on https://octoverse.github.com/ @torvalds @Subsurface-divelog 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment