Sebastian Valle
Subv

Organizations

@citra-emu
Aug 4, 2016
Subv commented on pull request citra-emu/citra#1986
@Subv

So, say I wanted to add a Bluetooth gamepad that uses a custom protocol, i'd just have to add another "DeviceFramework" to the enum, create a Custo…

Aug 4, 2016
Subv commented on pull request citra-emu/citra#1987
@Subv

LGTM

Aug 4, 2016
Subv commented on pull request citra-emu/citra#1948
@Subv

Should also create an issue about CRO hash verification, what should we do about that? enforcing it will break homebrew CROs

Aug 4, 2016
Subv commented on pull request citra-emu/citra#1948
@Subv

LGTM, you should create an issue about memory aliasing after this is merged, i'll tackle that on later.

Jul 20, 2016
Subv commented on issue citra-emu/citra#1960
@Subv

I'm in favour of removing it entirely Agreed, it's been broken since it's inception.

Jul 20, 2016
Subv commented on pull request citra-emu/citra#1963
@Subv

LGTM

Jul 14, 2016
Subv commented on pull request citra-emu/citra#1950
@Subv

Yeah but what does it mean? And how is it different than screen_capture_post_permission=1? That needs to be either documented in the code or left a…

Jul 14, 2016
Subv commented on pull request citra-emu/citra#1948
@Subv

Perhaps ReadCString?

Jul 14, 2016
Subv commented on pull request citra-emu/citra#1950
@Subv

What does CleanThePermission mean?

Jul 14, 2016
Subv commented on pull request citra-emu/citra#1951
@Subv

I think that's outside the scope of this PR and can be added on a future one so as to not clutter this one.

Jul 14, 2016
Subv closed issue citra-emu/citra#1949
@Subv
(possible regression) hard crash upon booting omega ruby
Jul 14, 2016
Subv commented on issue citra-emu/citra#1949
@Subv

Indeed, Pokemon has never worked.

Jul 13, 2016
Subv commented on pull request citra-emu/citra#1948
@Subv

<Normmatt> [08:21:08] http://i.imgur.com/7drHiqr.gif

Jul 9, 2016
Jul 7, 2016
Subv closed pull request citra-emu/citra#1911
@Subv
Kernel/IPC: Use Ports and Sessions as the fundamental building block of Inter Process Communication.
Jul 7, 2016
Subv commented on pull request citra-emu/citra#1911
@Subv

I'm closing this one until i feel like working on it again.

Jul 5, 2016
Subv pushed to master at citra-emu/citra
@Subv
Jul 5, 2016
Subv merged pull request citra-emu/citra#1921
@Subv
HLE/FS: Document some command parameters and implemented command 0x08560240
1 commit with 42 additions and 11 deletions
Jul 4, 2016
Subv pushed to master at citra-emu/citra
@Subv
Jul 4, 2016
Subv merged pull request citra-emu/citra#1850
@Subv
HLE/Applets: Implement ErrEula applet
1 commit with 118 additions and 0 deletions
Jul 3, 2016
Subv commented on commit wwylele/citra@5b0d61999c
@Subv

Since we know the max length, we can reserve enough space when constructing the std::string

Jul 3, 2016
Subv commented on pull request citra-emu/citra#1921
@Subv

Updated

Jul 3, 2016
Subv pushed to fs_funcs at Subv/citra
@Subv
  • @Subv 8752f07
    HLE/FS: Document some command parameters and implemented command 0x08…
Jul 3, 2016
Subv pushed to master at citra-emu/citra
@Subv
Jul 3, 2016
Subv merged pull request citra-emu/citra#1935
@Subv
Result: fix and update ErrorModule
1 commit with 19 additions and 6 deletions
Jul 3, 2016
Subv commented on issue citra-emu/citra#1938
@Subv

Ah, I remember having a bug like this in ALBW with the first implementation of scissor i had, it had to do with the viewport offsets not being take…

Jun 30, 2016
Subv commented on pull request citra-emu/citra#1935
@Subv

LGTM

Jun 28, 2016
Subv commented on pull request citra-emu/citra#1652
@Subv

Just revert it for now, see #1652 (comment)

Jun 28, 2016
Subv commented on pull request citra-emu/citra#1874
@Subv

What's the status of this?

Jun 28, 2016
Subv commented on pull request citra-emu/citra#1652
@Subv

Call for more reviews please, it's been more than 2 months already.