New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple bugs found after the latest release #38

Merged
merged 10 commits into from Jun 27, 2017

Conversation

Projects
None yet
2 participants
@cixtor
Contributor

cixtor commented Jun 27, 2017

This pull-request fixes two minor bugs found after the release of version 1.8.4; the first bug appears when the directory where the plugin stores its data is not writable, there is an exception that is not being handled gracefully. The second bug is a typo of the PHP function sprintf which was written as spritnf in the general settings page.

This pull-request also adds 100% support for internationalization, it includes the complete POT file for the English language as well as the full translation to Spanish (Latin American dialect). Hopefully, this will help external contributors to continue with the translation process of other languages.

This pull-request also includes a fix for the language file loader when the locale of the website is not supported. he plugin will check which language the website is to configured to use, if the plugin has no support for this language it will try to copy the English POT files (both the raw file and the compiled version) to a file with the same locale as the website. If the files cannot be copied the plugin will force the global locale variable to use English.

An additional fix for the invitation to subscribe to our newsletter is also included here. When the plugin detects that the version number of the plugin that was previously installed is different than the version that is currently installed, it assumes that the plugin has been updated. When this happens it displays a message in the admin dashboard inviting the users to subscribe to our newsletter. However, in some rare cases this fails because the HTTP headers has already been sent and the plugin throws an error. This commit fixes this problem by checking if the HTTP headers has already been sent before the alert is printed.

cixtor added some commits Jun 13, 2017

Fix the invitation to subscribe to our newsletter
When the plugin detects that the version number of the plugin that was
previously installed is different than the version that is currently
installed, it assumes that the plugin has been updated. When this
happens it displays a message in the admin dashboard inviting the users
to subscribe to our newsletter. However, in some rare cases this fails
because the HTTP headers has already been sent and the plugin throws an
error. This commit fixes this problem by checking if the HTTP headers
has already been sent before the alert is printed.
Fix language file loader when locale is not supported
The plugin will check which language the website is to configured to
use, if the plugin has no support for this language it will try to copy
the English POT files (both the raw file and the compiled version) to a
file with the same locale as the website. If the files cannot be copied
the plugin will force the global locale variable to use English.

@cixtor cixtor changed the title from Add changelog to release version 1.8.5 to Add changelog to release version 1.8.6 Jun 27, 2017

@cixtor cixtor changed the title from Add changelog to release version 1.8.6 to Fix multiple bugs found after the latest release Jun 27, 2017

@dcid dcid merged commit 19f174a into Sucuri:master Jun 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment