Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated subtype names (fatal), subtype names should not be localized #15

Open
blowfishpro opened this issue Oct 18, 2018 · 1 comment

Comments

@blowfishpro
Copy link

commented Oct 18, 2018

Here: https://github.com/SuicidalInsanity/Mk3Expansion/blob/cebe06184ecea6e0f9fce0b95152961fb5b641a0/Mk3Expansion-1.4.7/GameData/Mk3Expansion/Parts/Structural/FuselageExtension/cargoadapter.cfg

  1. The subtype name #LOC_CSaddleTank_Adapter is duplicated. This is invalid and now a fatal error
  2. Subtype names should not be localized. name is what is used to identify the current subtype in the craft file, so doing this will break craft if localizations change or when a craft is shared between installs with different localizations. There is a separate title parameter which will override the UI display and can be localized. You can even have duplicates if you want (though I don't recommend it for user experience reasons).

I haven't checked if (2) affects any other parts.

@blowfishpro

This comment has been minimized.

Copy link
Author

commented Oct 18, 2018

E: I see a lot of other localized subtype names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.