Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed AES #54

Merged
merged 4 commits into from Jan 23, 2015
Merged

Fixed AES #54

merged 4 commits into from Jan 23, 2015

Conversation

xAnavrins
Copy link
Contributor

In addition to the Key Schedule, the shiftRows, invShiftRows and mixColumns functions were also wrong.

@xAnavrins xAnavrins changed the title Fixed shiftRow and invShiftRow Fixed shiftRow, invShiftRow and mixColumns Jan 16, 2015
@xAnavrins xAnavrins changed the title Fixed shiftRow, invShiftRow and mixColumns Fixed AES Jan 20, 2015
@xAnavrins xAnavrins mentioned this pull request Jan 23, 2015
Closed
@dmarcuse
Copy link
Collaborator

So this PR fixes the problems noted in #53?

@xAnavrins
Copy link
Contributor Author

It fixes #53 and fixes some other crucial steps.
After testing with these change, it passes the test vectors shown in the official aes publication documents (http://csrc.nist.gov/publications/fips/fips197/fips-197.pdf)

dmarcuse pushed a commit that referenced this pull request Jan 23, 2015
Merge pull request #54 from xAnavrins/master
e137b48 
Fixed AES
@dmarcuse dmarcuse merged commit e137b48 into SuicidalSTDz:master Jan 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xAnavrins @dmarcuse