GuardDuty NodeJs update #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 7, 2021 15:45
…app. Adding serverless to template.
himanshu219
suggested changes
Apr 12, 2021
| }, | ||
| "Timeout": 300, | ||
| "Runtime": "nodejs10.x" | ||
| "Runtime": "nodejs12.x" |
Contributor
There was a problem hiding this comment.
I think we should upgrade it to node14
| - in | ||
| - fed | ||
| Description: "Enter au, ca, de, eu, jp, us2, or us1" | ||
| Description: "Enter in, fed, au, ca, de, eu, jp, us2, or us1" |
Contributor
There was a problem hiding this comment.
I haven't tested it on sumo's fed deployment. In fed there are some features/APIs not available like C2C so I don't know whether it works there or not.
Contributor
Author
There was a problem hiding this comment.
fed was already part of list. I just updated the description.
Contributor
There was a problem hiding this comment.
hmm the list is not a dropdown it's a validation I guess since the description is visible to customers so that's why they didn't tried entering fed but ok lets see if anyone complaints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Cloudwatch events templates to use nodejs12.x version