Skip to content

Conversation

@JV0812
Copy link
Collaborator

@JV0812 JV0812 commented Jan 28, 2025

Purpose of this pull request

This pull request is to revamp the Release note landing page and Guides dropdown.

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Jan 28, 2025
@JV0812 JV0812 self-assigned this Jan 28, 2025
@JV0812 JV0812 marked this pull request as draft January 28, 2025 05:17
Copy link
Collaborator

@kimsauce kimsauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JV0812 , thanks again for doing this! I know it's still a draft in progress, but I've added comments.

JV0812 and others added 5 commits January 28, 2025 12:29
Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
Copy link
Collaborator

@kimsauce kimsauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added the RSS links and icons

@JV0812
Copy link
Collaborator Author

JV0812 commented Jan 29, 2025

Thanks Kim, Instead of Dashboards icon I have added the Mange icon since it also has a gear icon within it. Also, the space after the Card name is just to avoid overlapping of RSS icon with the name.

@JV0812 JV0812 marked this pull request as ready for review January 29, 2025 07:29
@JV0812 JV0812 requested a review from kimsauce January 29, 2025 07:29
@kimsauce
Copy link
Collaborator

kimsauce commented Jan 29, 2025

Thanks Kim, Instead of Dashboards icon I have added the Mange icon since it also has a gear icon within it. Also, the space after the Card name is just to avoid overlapping of RSS icon with the name.

Yes, but that omits the RSS xml links @JV0812
Screenshot 2025-01-29 at 12 41 50 AM

@kimsauce kimsauce closed this Jan 29, 2025
@kimsauce kimsauce reopened this Jan 29, 2025
@kimsauce
Copy link
Collaborator

@JV0812 sorry, I accidentally clicked "Close"! All good now. Could you add back the RSS xml links?

Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @JV0812.

Copy link
Collaborator

@kimsauce kimsauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs to RSS links

JV0812 and others added 2 commits January 30, 2025 15:25
Co-authored-by: John Pipkin (Sumo Logic) <jpipkin@sumologic.com>
@JV0812 JV0812 requested a review from kimsauce January 30, 2025 10:03
@JV0812
Copy link
Collaborator Author

JV0812 commented Jan 30, 2025

updated accordingly and publishing the PR.

@JV0812 JV0812 enabled auto-merge January 30, 2025 10:09
@JV0812 JV0812 dismissed kimsauce’s stale review January 30, 2025 10:36

comments incorporated.

@JV0812 JV0812 added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 8129dc1 Jan 30, 2025
7 checks passed
@JV0812 JV0812 deleted the test-guides-dropdown branch January 30, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Contributor approved, listed in .clabot file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants