Add Azure Key Vaults Doc changes with Dashboards and alerts #5188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apoorvkudesia-sumologic
requested review from
a team,
JV0812,
amee-sumo,
jpipkin1,
kimsauce and
mafsumo
as code owners
jpipkin1
approved these changes
Mar 19, 2025
Collaborator
jpipkin1
left a comment
jpipkin1
left a comment
There was a problem hiding this comment.
Approved, @Apoorvkudesia-sumologic. I made some minor changes. See commits "Updates from review" and "Remove duplicate step".
amee-sumo
requested changes
Mar 20, 2025
Collaborator
amee-sumo
left a comment
amee-sumo
left a comment
There was a problem hiding this comment.
Made a few suggestions. Rest LGTM
himanshu219
reviewed
Mar 21, 2025
himanshu219
reviewed
Mar 21, 2025
himanshu219
reviewed
Mar 21, 2025
himanshu219
reviewed
Mar 21, 2025
amee-sumo
approved these changes
Mar 21, 2025
Collaborator
amee-sumo
left a comment
amee-sumo
left a comment
There was a problem hiding this comment.
Reviewed the new changes. LGTM
himanshu219
reviewed
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Docs changes to cater the change of Azure Key Vaults app from doc only to normal app.
Addition of new Dashboards and monitors.
Updates in content in app setup section
This pull request...
Select the type of change
Ticket (if applicable)