From fdbff12f18b095a6feb109647ea37da39459f519 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miko=C5=82aj=20=C5=9Awi=C4=85tek?= Date: Mon, 13 Feb 2023 13:01:48 +0100 Subject: [PATCH] feat: disable otel storage compaction on start With on_rebound compaction enabled, this isn't necessary anymore, and it causes long startup times when the queue is large. --- .changelog/2870.changed.txt | 1 + deploy/helm/sumologic/conf/logs/collector/otelcol/config.yaml | 1 - deploy/helm/sumologic/conf/logs/otelcol/config.yaml | 1 - deploy/helm/sumologic/conf/metrics/otelcol/config.yaml | 1 - tests/helm/logs_otc/static/basic.output.yaml | 1 - tests/helm/logs_otc/static/options.output.yaml | 1 - tests/helm/metadata_logs_otc/static/otel.output.yaml | 1 - tests/helm/metadata_logs_otc/static/templates.output.yaml | 1 - .../metadata_metrics_otc/static/additional_endpoints.output.yaml | 1 - tests/helm/metadata_metrics_otc/static/basic.output.yaml | 1 - 10 files changed, 1 insertion(+), 9 deletions(-) create mode 100644 .changelog/2870.changed.txt diff --git a/.changelog/2870.changed.txt b/.changelog/2870.changed.txt new file mode 100644 index 0000000000..fe2038ce3a --- /dev/null +++ b/.changelog/2870.changed.txt @@ -0,0 +1 @@ +feat: disable otel storage compaction on start \ No newline at end of file diff --git a/deploy/helm/sumologic/conf/logs/collector/otelcol/config.yaml b/deploy/helm/sumologic/conf/logs/collector/otelcol/config.yaml index df6c446454..6546a6c417 100644 --- a/deploy/helm/sumologic/conf/logs/collector/otelcol/config.yaml +++ b/deploy/helm/sumologic/conf/logs/collector/otelcol/config.yaml @@ -4,7 +4,6 @@ extensions: directory: /var/lib/storage/otc timeout: 10s compaction: - on_start: true on_rebound: true # Can't be /tmp yet, see https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/13449 directory: /var/lib/storage/otc diff --git a/deploy/helm/sumologic/conf/logs/otelcol/config.yaml b/deploy/helm/sumologic/conf/logs/otelcol/config.yaml index 39e9c4cc5d..db833af780 100644 --- a/deploy/helm/sumologic/conf/logs/otelcol/config.yaml +++ b/deploy/helm/sumologic/conf/logs/otelcol/config.yaml @@ -18,7 +18,6 @@ extensions: directory: /var/lib/storage/otc timeout: 10s compaction: - on_start: true on_rebound: true # Can't be /tmp yet, see https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/13449 directory: /var/lib/storage/otc diff --git a/deploy/helm/sumologic/conf/metrics/otelcol/config.yaml b/deploy/helm/sumologic/conf/metrics/otelcol/config.yaml index cf05e501f2..2d7793851b 100644 --- a/deploy/helm/sumologic/conf/metrics/otelcol/config.yaml +++ b/deploy/helm/sumologic/conf/metrics/otelcol/config.yaml @@ -26,7 +26,6 @@ extensions: directory: /var/lib/storage/otc timeout: 10s compaction: - on_start: true on_rebound: true # Can't be /tmp yet, see https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/13449 directory: /var/lib/storage/otc diff --git a/tests/helm/logs_otc/static/basic.output.yaml b/tests/helm/logs_otc/static/basic.output.yaml index dd745c1be4..3b70f02f37 100644 --- a/tests/helm/logs_otc/static/basic.output.yaml +++ b/tests/helm/logs_otc/static/basic.output.yaml @@ -19,7 +19,6 @@ data: compaction: directory: /var/lib/storage/otc on_rebound: true - on_start: true directory: /var/lib/storage/otc timeout: 10s health_check: {} diff --git a/tests/helm/logs_otc/static/options.output.yaml b/tests/helm/logs_otc/static/options.output.yaml index 8a23a87606..ddb1e53eaa 100644 --- a/tests/helm/logs_otc/static/options.output.yaml +++ b/tests/helm/logs_otc/static/options.output.yaml @@ -19,7 +19,6 @@ data: compaction: directory: /var/lib/storage/otc on_rebound: true - on_start: true directory: /var/lib/storage/otc timeout: 10s health_check: {} diff --git a/tests/helm/metadata_logs_otc/static/otel.output.yaml b/tests/helm/metadata_logs_otc/static/otel.output.yaml index 81118fb11c..1ba097aa1b 100644 --- a/tests/helm/metadata_logs_otc/static/otel.output.yaml +++ b/tests/helm/metadata_logs_otc/static/otel.output.yaml @@ -41,7 +41,6 @@ data: compaction: directory: /var/lib/storage/otc on_rebound: true - on_start: true directory: /var/lib/storage/otc timeout: 10s health_check: {} diff --git a/tests/helm/metadata_logs_otc/static/templates.output.yaml b/tests/helm/metadata_logs_otc/static/templates.output.yaml index c85707f505..9add6346f5 100644 --- a/tests/helm/metadata_logs_otc/static/templates.output.yaml +++ b/tests/helm/metadata_logs_otc/static/templates.output.yaml @@ -41,7 +41,6 @@ data: compaction: directory: /var/lib/storage/otc on_rebound: true - on_start: true directory: /var/lib/storage/otc timeout: 10s health_check: {} diff --git a/tests/helm/metadata_metrics_otc/static/additional_endpoints.output.yaml b/tests/helm/metadata_metrics_otc/static/additional_endpoints.output.yaml index 80b4332cba..6f2855402f 100644 --- a/tests/helm/metadata_metrics_otc/static/additional_endpoints.output.yaml +++ b/tests/helm/metadata_metrics_otc/static/additional_endpoints.output.yaml @@ -97,7 +97,6 @@ data: compaction: directory: /var/lib/storage/otc on_rebound: true - on_start: true directory: /var/lib/storage/otc timeout: 10s health_check: {} diff --git a/tests/helm/metadata_metrics_otc/static/basic.output.yaml b/tests/helm/metadata_metrics_otc/static/basic.output.yaml index a7e886588d..be00d0eb09 100644 --- a/tests/helm/metadata_metrics_otc/static/basic.output.yaml +++ b/tests/helm/metadata_metrics_otc/static/basic.output.yaml @@ -97,7 +97,6 @@ data: compaction: directory: /var/lib/storage/otc on_rebound: true - on_start: true directory: /var/lib/storage/otc timeout: 10s health_check: {}