New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integer overflow in mintTokens #1
Comments
|
Any update? @lukapusic |
|
Correct me if I'm wrong, but AFAICS the first line of this function will prevent unauthorized use, effectively mitigating the vulnerability. |
|
@NieDzejkob correct, the first line makes sure that only the ICO contract can mint tokens. Since ICO contract cannot mint tokens because the ICO has ended, this does not pose a problem. There are safeguards in the ICO contract which prevent it from minting new tokens. |
|
Yes,you are correct.I don't notice the first line. |
Hello,
I have found an integer overflow in mintTokens,the supply variable could overflow,because of the _amount variable is controlled by us and can eventually cause supply overflow to zero.
Discovered by zhihua.yao@dbappsecurity.com.cn(hackyzh)
The text was updated successfully, but these errors were encountered: