all layers should use Meta #62

Closed
mikofski opened this Issue Oct 1, 2016 · 0 comments

Projects

In Progress in Carousel-v0.3.5

1 participant

@mikofski
Contributor
mikofski commented Oct 1, 2016

instead of popping class attributes, or using set_param_file_or_parameters, we should get parameters as Fields and everything else as Meta so that user can put whatever class attributes he or she wants

@mikofski mikofski added the enhancement label Oct 1, 2016
@mikofski mikofski self-assigned this Oct 1, 2016
@mikofski mikofski added this to the v0.3 milestone Oct 6, 2016
@mikofski mikofski added a commit to mikofski/Carousel that referenced this issue Oct 17, 2016
@mikofski mikofski separate formulas, use Meta and FormulaParameter
* closes #64 - formulas are separated, no more formula keyword, all formulas are in parameters
* addresses #62 - formulas use Meta for module, package and path
* adresses #40 - very similar to #62, but now formulas has Meta too
* closed #6 - use meta_names to instantiate attributes for registries, this actually already happened in a recent commit
* extract Meta from parameter files if it's there using type("Meta", (), file_params.pop('Meta')) pretty easy
* read in formulas from param file as FormulaParameters instead of just dictionaries
* fix some of the pvpower example files: newstyle model and formula json files
4694f16
@mikofski mikofski modified the milestone: v0.3, v0.3.5 Nov 1, 2016
@mikofski mikofski closed this in 77cee29 Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment