split calculations into separate fields #63

Closed
mikofski opened this Issue Oct 5, 2016 · 1 comment

Projects

In Progress in Carousel-v0.3.5

1 participant

@mikofski
Contributor
mikofski commented Oct 5, 2016 edited

splitting calculations into separate fields has several advantages:

  1. they can have separate dependencies
  2. topographical sort in simulation can be used to order all of them
  3. the DAG can determine which solvers/calculators to use and whether the simulation can be parallelized, ie: if calculations can be performed simultaneously
  4. calculations __metaclass__ would be more meaningful, rather than just a scraper of values.
@mikofski mikofski self-assigned this Oct 5, 2016
@mikofski mikofski added this to the v0.3 milestone Oct 6, 2016
@mikofski mikofski removed the question label Oct 6, 2016
@mikofski
Contributor
mikofski commented Oct 6, 2016

although this may be some work, I'm loving this more and more. stretch goal to make it into v0.3

@mikofski mikofski modified the milestone: v0.3, v0.3.5 Nov 1, 2016
@mikofski mikofski added a commit to mikofski/Carousel that referenced this issue Nov 12, 2016
@mikofski mikofski start working on issue #63 splitting calculations into separate param…
…eters

* move set attr param_file before reading file, oops!
* add _param_cls to calculations, outputs and simulations
* also use mcs.set_meta() in formulas, calculations, outputs and simulations
* remove reading param files, since already doing it in set_param_or parameters in common base
* add test to see if data parameters from file are also updated from  class parameters
* change simulation param file to have a settings key
* move class dependencies and calculators from param file to Meta in model calc classes
6867618
@mikofski mikofski closed this in 77cee29 Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment