Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to module syntax, support React Native for Web #49

Merged
merged 1 commit into from Mar 20, 2019

Conversation

Projects
None yet
2 participants
@EyMaddis
Copy link
Contributor

EyMaddis commented Mar 18, 2019

This PR switches to the Ecmascript Module Syntax.
Switching from commonJs allows tree shaking to work which is especially relevant on the web.

Enables support for React Native for Web.

I also unified the interface of the package the be the same for all platforms.

@Sunhat

Sunhat approved these changes Mar 20, 2019

@Sunhat Sunhat merged commit 0d118b7 into Sunhat:master Mar 20, 2019

@Sunhat

This comment has been minimized.

Copy link
Owner

Sunhat commented Mar 20, 2019

Greatly appreciated my dude

@Sunhat

This comment has been minimized.

Copy link
Owner

Sunhat commented Mar 20, 2019

By any chance, are you running into this build issue in one of the tickets?

@Sunhat

This comment has been minimized.

Copy link
Owner

Sunhat commented Mar 20, 2019

#47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.