Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test with classes on objects being overridden by another #52

Closed
wants to merge 1 commit into from

Conversation

@Julusian
Copy link
Member

commented Aug 9, 2019

class0 does not appear in the resolved state, so video2 should not either. This can cause unexpected behaviour when having two objects like video0 and video1 as other objects can leak through.

The same is true if both video0 and video1 have absolute start times, and can be resolved by giving video0 an end

@nytamin

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

This behavior is kind-of intended, currently.

The resolving of the timeline is done in two phases:

  1. References to objects are looked up and resolved into instances. Instances are capped within their parents.
  2. Instances that collide are merged, split, or shortened

Since the reference lookups are done before any collisions are handled, the downstream references won't be affected by the collision.

One could argue that the timeline should handle the references to take this into account, but I believe that could open a Pandoras box, with circular references that could be very hard to foresee, and that could happen just because an object is moved a little in the timeline. Therefore I'm reluctant to make this happen.

@nytamin nytamin closed this Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.