Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the music fade out on death be removed? #1470

Closed
Alzter opened this issue Jul 18, 2020 · 7 comments
Closed

Should the music fade out on death be removed? #1470

Alzter opened this issue Jul 18, 2020 · 7 comments
Labels
status:needs-discussion Team member and developers need to discuss of decisions

Comments

@Alzter
Copy link
Member

Alzter commented Jul 18, 2020

It seems weird for the music to fade out when Tux dies, considering it just resumes anyway. Should the fade out/in be removed?

@Alzter Alzter added the status:needs-discussion Team member and developers need to discuss of decisions label Jul 18, 2020
@Alzter
Copy link
Member Author

Alzter commented Jul 18, 2020

Made a PR for this #1472

@busybody42
Copy link
Contributor

keep it.

@Alasdairbugs
Copy link
Contributor

it should be removed, its clunky, and for levels where you die a lot, it just gets annoying and buggy. it sometimes just cuts out all together.

@Ordoviz
Copy link
Contributor

Ordoviz commented Jul 18, 2020

I like the fade-out/fade-in if you wait during the die animation. But I always press Esc to skip the animation which instantly stops the music. Because of that I support the removal.

@busybody42
Copy link
Contributor

I think it should instantly skip the fade out if you skipped the death cutscene...

@tux314159
Copy link
Contributor

And maybe also let the music continue after a restart?

@MrIceblock
Copy link

Keep it, IMO it would be nice if the music fades out upon death and fade back in upon revival.

@SuperTux SuperTux locked and limited conversation to collaborators Dec 27, 2021
@Semphriss Semphriss converted this issue into discussion #2037 Dec 27, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
status:needs-discussion Team member and developers need to discuss of decisions
Projects
None yet
Development

No branches or pull requests

6 participants