New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New badguy: HangingBall #367
Conversation
What about having a different sound for this instead of the cracking sound used for stalactites? |
@tobbi Do I look as someone who can hear properly? |
Sound taken from: http://freesound.org/people/juskiddink/sounds/140867/ |
OK, the sound was Tobbi's joke. So it's a placeholder for now. |
How about https://freesound.org/people/kvgarlic/sounds/184547/ as sound? |
b2e04fc
to
e917d3e
Compare
src/badguy/stalactite.cpp
Outdated
@@ -36,7 +37,7 @@ Stalactite::Stalactite(const ReaderMapping& lisp) : | |||
{ | |||
countMe = false; | |||
set_colgroup_active(COLGROUP_TOUCHABLE); | |||
SoundManager::current()->preload("sounds/cracking.wav"); | |||
SoundManager::current()->preload(get_cracking_sound_path()); | |||
SoundManager::current()->preload("sounds/sizzle.ogg"); | |||
SoundManager::current()->preload("sounds/icecrash.ogg"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two other sounds should also get an option so they can be changed for Hanging Ball.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icecrash seems reasonable, but the sizzle is generic for melting process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.
src/badguy/stalactite.cpp
Outdated
return "sounds/cracking.wav"; | ||
} | ||
|
||
HangingBall::HangingBall(const ReaderMapping& reader) : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use a file per class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already in some other cases. This is not the only one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That does not mean we should continue to do so.
src/badguy/stalactite.hpp
Outdated
protected: | ||
Timer timer; | ||
StalactiteState state; | ||
Vector shake_delta; | ||
}; | ||
|
||
class HangingBall : public Stalactite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use a file per class.
It's a forest equivalent of stalactite.
This comment was marked as off-topic.
This comment was marked as off-topic.
a good concept, but hanging ball is not the most creative thing we could use. |
Obviously, we are not going to use this. Hume2 has not been active for a very long time. Can someone close this? |
It's a forest equivalent of stalactite.