Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New badguy: HangingBall #367

Closed
wants to merge 1 commit into from
Closed

New badguy: HangingBall #367

wants to merge 1 commit into from

Conversation

Hume2
Copy link
Member

@Hume2 Hume2 commented Feb 18, 2016

It's a forest equivalent of stalactite.

@Hume2 Hume2 added this to the 0.5.0 milestone Feb 22, 2016
@tobbi
Copy link
Member

tobbi commented Feb 24, 2016

What about having a different sound for this instead of the cracking sound used for stalactites?

@Hume2
Copy link
Member Author

Hume2 commented Feb 24, 2016

@tobbi Do I look as someone who can hear properly?

@Hume2
Copy link
Member Author

Hume2 commented Mar 19, 2016

Sound taken from: http://freesound.org/people/juskiddink/sounds/140867/
It's in data/AUTHORS anyway.

@Hume2
Copy link
Member Author

Hume2 commented Mar 19, 2016

OK, the sound was Tobbi's joke. So it's a placeholder for now.

@maxteufel maxteufel modified the milestones: Post 0.5.0, 0.5.0 Jun 18, 2016
@maxteufel
Copy link
Member

How about https://freesound.org/people/kvgarlic/sounds/184547/ as sound?

@maxteufel maxteufel modified the milestones: 0.6.0, Future Aug 29, 2016
@Hume2 Hume2 self-assigned this Oct 22, 2016
@Hume2 Hume2 added category:code category:design status:needs-work In progress, but no one is currently working on it (New volunteers welcome) type:feature labels Oct 22, 2016
@@ -36,7 +37,7 @@ Stalactite::Stalactite(const ReaderMapping& lisp) :
{
countMe = false;
set_colgroup_active(COLGROUP_TOUCHABLE);
SoundManager::current()->preload("sounds/cracking.wav");
SoundManager::current()->preload(get_cracking_sound_path());
SoundManager::current()->preload("sounds/sizzle.ogg");
SoundManager::current()->preload("sounds/icecrash.ogg");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two other sounds should also get an option so they can be changed for Hanging Ball.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icecrash seems reasonable, but the sizzle is generic for melting process.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

return "sounds/cracking.wav";
}

HangingBall::HangingBall(const ReaderMapping& reader) :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a file per class.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already in some other cases. This is not the only one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does not mean we should continue to do so.

protected:
Timer timer;
StalactiteState state;
Vector shake_delta;
};

class HangingBall : public Stalactite
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a file per class.

It's a forest equivalent of stalactite.
@busybody42

This comment was marked as off-topic.

@weluvgoatz
Copy link
Member

a good concept, but hanging ball is not the most creative thing we could use.

@tobbi tobbi modified the milestones: 0.6.0, Future Dec 10, 2018
@weluvgoatz
Copy link
Member

Obviously, we are not going to use this. Hume2 has not been active for a very long time. Can someone close this?

@HybridDog HybridDog closed this Nov 2, 2019
@Rusty-Box Rusty-Box removed this from Other Improvements in Rooted Forest Overhaul Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:code category:design status:needs-work In progress, but no one is currently working on it (New volunteers welcome) type:feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants