Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Superprovider is always fed with the previously selected account #86

Closed
bashlund opened this issue Nov 5, 2019 · 0 comments · Fixed by #103
Closed

The Superprovider is always fed with the previously selected account #86

bashlund opened this issue Nov 5, 2019 · 0 comments · Fixed by #103
Assignees
@bashlund
Labels
bug Something isn't working
Projects
Release-1

Comments

@bashlund
Copy link
Contributor

bashlund commented Nov 5, 2019

Environment/Browser

Chromium

Description

When working with the preview and changing accounts, the preview/dapp/superprovider always get setAccount() for the previously selected account.

Steps to reproduce

  1. Create Hello World dapp
  2. Output accounts in the dapp (window.web3.eth.accounts and this.web3.eth.getAccounts( function (err, res) {console.log("getAccounts", res)});)
  3. Create new accounts
  4. Switch between accounts
  5. Observe how the accessible account is always the previously selected account.

Expected result

To get the currently selected account.

Actual result

Always get the previously selected account.

Reproducable

Yes
@bashlund bashlund added the bug Something isn't working label Nov 5, 2019
@bashlund bashlund added this to To do in Release-1 Nov 5, 2019
@bashlund bashlund mentioned this issue Nov 5, 2019
Merged
@bashlund bashlund self-assigned this Nov 5, 2019
@bashlund bashlund moved this from To do to In progress in Release-1 Nov 6, 2019
bashlund added a commit to bashlund/ethereum-studio that referenced this issue Nov 6, 2019
@bashlund
+ Fix SuperblocksHQ#86
b6b6f4a 
+ Fix missing update of iframe content
@bashlund bashlund mentioned this issue Nov 6, 2019
Merged
@filippsen filippsen moved this from In progress to Review in progress in Release-1 Nov 7, 2019
@bashlund bashlund mentioned this issue Nov 7, 2019
Closed
Release-1 automation moved this from Review in progress to Done Nov 8, 2019
bashlund added a commit that referenced this issue Nov 8, 2019
@bashlund
Merge pull request #103 from bashlund/fix-86-superprovider-always-fed…
7c15465 
…-with-previous-account

Fix #86 - Superprovider always fed with previously selected account
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bashlund bashlund

Labels
bug Something isn't working
Projects
Release-1
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #86 - Superprovider always fed with previously selected account bashlund/ethereum-studio
1 participant
@bashlund