TimeoutHTTPSConnection fixes #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
This PR is mixing a lot of unrelated changes (an SSL fix, new features, and PEP8 style changes). If you want to submit a focused PR that just fixes |
Contributor
Author
|
@mnaberez ok, I'll try to separate the settimeout fix out. |
philiptzou
force-pushed
the
pull-request-https-timeout
branch
from
a762f9e to
51a7e34
Compare
philiptzou
changed the title
Contributor
Author
|
@mnaberez the |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a replication of #9, which issued 3 years ago but never get merged. I rebased the old revisions onto latestsuperlanceand did some PEP8 fix, that's all.The reason I want to help it being merged is that I ran into the same problem ('NoneType' object has no attribute 'settimeout'). At the beginning I thought to fix it by my own but soon I found someone already did it in #9.This time just try to fix the
'NoneType' object has no attribute 'settimeout'problem when usingTimeoutHTTPSConnection.