New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supervisorctl doesn't load included config files, misleading and undocumented #1007

Closed
farialima opened this Issue Oct 21, 2017 · 3 comments

Comments

2 participants
@farialima

farialima commented Oct 21, 2017

I have supervisor 3.2.0 on ubuntu 16.10, installed from the ubuntu package.

I was unable to use supervisorctl, even when providing the -c option:

$ supervisorctl
unix:///var/run/supervisor.sock no such file
supervisor> exit
$ supervisorctl -c /etc/supervisor/supervisord.conf 
unix:///var/run/supervisor.sock no such file
supervisor> 

The reason is that I had customized the socket (so that it's not in a root-owned folder) used by supervisor in an included config file. I.e. I have the unmodified default Debian/Ubuntu config /etc/supervisor/supervisord.conf:

[supervisorctl]
serverurl=unix:///var/run/supervisor.sock
(...)
[include]
files = /etc/supervisor/conf.d/*.conf

and I have added a /etc/supervisor/conf.d/my.conf that contains (among other things):

[supervisorctl]
serverurl=unix:///var/run/supervisor/supervisor.sock

However, that setting is not taken in account by supervisorctl... it took me to look in the code (in ClientOptions) to see that supervisorctl doesn't load the config files listed in the [include] section... This is quite misleading, and not documented in http://supervisord.org/running.html#running-supervisorctl ...

@farialima farialima changed the title from supervisorctl doesn't load included config files to supervisorctl doesn't load included config files, misleading and undocumented Oct 21, 2017

@farialima

This comment has been minimized.

Show comment
Hide comment
@farialima

farialima Oct 21, 2017

related to #498 (i.e. supervisord config != supervisorcrtl config) At least it would be worth documenting it ?

farialima commented Oct 21, 2017

related to #498 (i.e. supervisord config != supervisorcrtl config) At least it would be worth documenting it ?

@farialima

This comment has been minimized.

Show comment
Hide comment
@farialima

farialima commented Oct 21, 2017

see also #480

@mnaberez

This comment has been minimized.

Show comment
Hide comment
@mnaberez

mnaberez Oct 21, 2017

Member

There is an open pull request for this in #277. I will close this issue in favor of that one.

Member

mnaberez commented Oct 21, 2017

There is an open pull request for this in #277. I will close this issue in favor of that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment