New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for fcgi-programs in groups? #148

Closed
Einkoro opened this Issue Sep 6, 2012 · 6 comments

Comments

6 participants
@Einkoro
Copy link

Einkoro commented Sep 6, 2012

Supervisord fails to start when I add a fcgi-program to a group and I found the following patch adding support in the mailing list from 2009. Would it be possible to add the patch?

http://lists.supervisord.org/pipermail/supervisor-users/attachments/20090605/98b18fb8/attachment.obj

@jeffjose

This comment has been minimized.

Copy link

jeffjose commented May 22, 2013

I just ran into a case where I could have used this feature. Will it be possible to merge Einkoro's code changes?

@Einkoro

This comment has been minimized.

Copy link
Author

Einkoro commented May 22, 2013

It looks like the line numbers referenced in the patch would be different now but the code it replaces hasn't changed. Should be easy enough to fork supervisor, make the changes and open a pull request. If I have some time on the weekend I could give this a go myself.

@mwicat

This comment has been minimized.

Copy link

mwicat commented Mar 7, 2016

@mnaberez Any plans to merge this? We use fcgi-program directive to balance traffic between multiple processes but we have separate program invocations for different protocols like xmpp, http etc. (=many fcgi-program directives) which we would like to treat as a group during deployments. Not to mention that treating [fcgi-program] as different entity than [program] despite the only difference being usage of shared sockets is rather hurting cohesiveness...

@mnaberez

This comment has been minimized.

Copy link
Member

mnaberez commented Mar 7, 2016

This patch looks reasonable but I have not tried it. It will need test coverage before it can be merged. I'll leave this issue open.

@mlowicki

This comment has been minimized.

Copy link

mlowicki commented Mar 8, 2016

@Einkoro are you able to add tests?

@mnaberez mnaberez removed the enhancement label Aug 24, 2016

@apollo13

This comment has been minimized.

Copy link
Contributor

apollo13 commented Oct 22, 2018

@mnaberez I've updated the code and added tests in #1163 -- please tell me what else you'd like to see.

@mnaberez mnaberez closed this in 27bdfd3 Jan 7, 2019

mnaberez added a commit that referenced this issue Jan 7, 2019

Merge pull request #1163 from apollo13/fcgi-groups
Added support for fcgi-program in groups, fixes #148.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment