New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run a handful of key flake8 tests on all new PRs #1040

Merged
merged 2 commits into from Jan 12, 2018

Conversation

2 participants
@cclauss
Contributor

cclauss commented Jan 11, 2018

Look for syntax errors or undefined names in both Python 2 and Python 3.

cclauss added some commits Jan 11, 2018

Run a handful of key flake8 tests on all new PRs
Look for syntax errors or undefined names in both Python 2 and Python 3.
@cclauss

This comment has been minimized.

Show comment
Hide comment
@cclauss

cclauss Jan 11, 2018

Contributor

Python 2 will pass these flake8 tests. Python 3 output matches #1039

Contributor

cclauss commented Jan 11, 2018

Python 2 will pass these flake8 tests. Python 3 output matches #1039

@mnaberez mnaberez merged commit 693b982 into Supervisor:master Jan 12, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

mnaberez added a commit that referenced this pull request Jan 12, 2018

Revert "Merge pull request #1040 from cclauss/patch-1"
This reverts commit 693b982, reversing
changes made to 3fcf16f.

This seems to cause many new build failures unrelated to flake8.

Before:
https://travis-ci.org/Supervisor/supervisor/builds/327894256

After:
https://travis-ci.org/Supervisor/supervisor/builds/327894256
@mnaberez

This comment has been minimized.

Show comment
Hide comment
@mnaberez

mnaberez Jan 12, 2018

Member

I had to revert this because it seems to cause many unrelated CI failures (before merge passed, after merge failed, after revert passed).

Member

mnaberez commented Jan 12, 2018

I had to revert this because it seems to cause many unrelated CI failures (before merge passed, after merge failed, after revert passed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment