Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
tox.ini: Switch to use py.test #527
because it's awesome.
This might be more controversial, since test runners can be a bit of a religion...
I often find it very useful in particular to run just a single test or a small subset of the tests. The supervisor test suite is pretty darned fast at this point so it's not a huge deal but maybe it could be later if we added more extensive integration tests.
pytest's fixture mechanism (dependency injection) is pretty awesome too and can lead to powerful and succint tests.
I would prefer to defer solutions for a slow test suite to a time when we have that issue.
I'm not keen on adding more dependencies to Supervisor. I think it could be alright as an optional dependency (like how we use
I guess overall I'm 0 or -1 on this change. @mcdonc what do you think?
It would replace nose in tests_require so I don't think it's an extra dependency.I'm a huge fan of Holger Krekel's, so I'm not actively against a merge.
That said, it's one of those things that is kinda meh. I'm 0 on it as well. nose-selecttests can be used to do same if running a subset is the main driving use case.
I think if both me and Mike come down as 0 on it and Marc wants it, we should merge it if it means Marc thinks he can contribute more easily, cuz Marc has done a boatload in supervisor so far.