Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
password option in genkeys() #1
Thanks for your work on this package! I've been playing with it a bit and exploring the API and have two suggestions related to the setting of the password in
The first is to suggest exposing the
You could easily refactor the password prompt into
and set the default value of
The second suggestion is that on RStudio the prompt is quite jumbled when displayed.
The above refactoring also displays properly in RStudio.
Finally, while looking at
If you're interested in the above I could quickly work these suggestions into a PR.
Many thanks for this and the work in the pull request. It is greatly appreciated.
It's also worth noting that
I guess I feel pretty strongly about not allowing users the option to make a mistake with a password. Together with wanting to go to information governance authorities and say we are using a system in which the password is not recorded in the script.
An alternative (that may be over thinking it) is to have
Thanks again for this help and discussion. I should have said above that I haven't incorporated the