Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update genkeys() interface #2

Closed
wants to merge 6 commits into from

Conversation

Projects
None yet
2 participants
@gadenbuie
Copy link

commented Feb 25, 2019

The changes I mentioned in #1 were pretty straightforward so I went ahead and implemented them.

I also added tests and updated the dependencies appropriately in DESCRIPTION.

One small note, I added askpass to Imports because openssl::askpass() is simply a re-export of askpass, so this won't increase the dependency weight of encryptr but does make the dependency graph more clear.

ewenharrison added a commit that referenced this pull request Feb 26, 2019

@ewenharrison

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2019

All changes made. Thanks again.

ewenharrison added a commit that referenced this pull request Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.