New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression in 1.10 #109
Comments
Whack, sorry I've not gotten back to you earlier. I didn't think at the time, but it worries me we're triggering the validation check every time we render stuff. It'd make more sense for me to use errors THEN validation, but that introduces another possible issue. @fvioz any thoughts from your intended use case if just checking errors would help? |
Sorry for a late response, I was on vacations, yep @Sutto are right It's better use errors in that case and don't trigger the validations every render, that's affects directly the performance of the api. |
Cool, I'll fix this and merge it in - Sorry again about such a long delay in getting this looked again. |
Commit 0f5a0a2 introduced an invalid check on respond able which causes an edge case error for me.
In my models I have some before_validation callbacks which change the attributes (like merging two data & time
attr_accessor
s into date time field). Normally Rails doesn't run validations when object is destroyed. However with this commit object validations are always run, and seems like AR object@attributes
hash is frozen prior to destruction which causes an error.Backtrace
The text was updated successfully, but these errors were encountered: