diff --git a/adapter/src/main/java/eu/happycoders/shop/adapter/out/persistence/inmemory/InMemoryCartRepository.java b/adapter/src/main/java/eu/happycoders/shop/adapter/out/persistence/inmemory/InMemoryCartRepository.java index 14d10b6..3d8a373 100644 --- a/adapter/src/main/java/eu/happycoders/shop/adapter/out/persistence/inmemory/InMemoryCartRepository.java +++ b/adapter/src/main/java/eu/happycoders/shop/adapter/out/persistence/inmemory/InMemoryCartRepository.java @@ -27,7 +27,7 @@ public Optional findByCustomerId(CustomerId customerId) { } @Override - public void deleteById(CustomerId customerId) { + public void deleteByCustomerId(CustomerId customerId) { carts.remove(customerId); } } diff --git a/adapter/src/main/java/eu/happycoders/shop/adapter/out/persistence/jpa/JpaCartRepository.java b/adapter/src/main/java/eu/happycoders/shop/adapter/out/persistence/jpa/JpaCartRepository.java index 1369827..572a95a 100644 --- a/adapter/src/main/java/eu/happycoders/shop/adapter/out/persistence/jpa/JpaCartRepository.java +++ b/adapter/src/main/java/eu/happycoders/shop/adapter/out/persistence/jpa/JpaCartRepository.java @@ -41,7 +41,7 @@ public Optional findByCustomerId(CustomerId customerId) { } @Override - public void deleteById(CustomerId customerId) { + public void deleteByCustomerId(CustomerId customerId) { try (EntityManager entityManager = entityManagerFactory.createEntityManager()) { entityManager.getTransaction().begin(); diff --git a/adapter/src/test/java/eu/happycoders/shop/adapter/out/persistence/AbstractCartRepositoryTest.java b/adapter/src/test/java/eu/happycoders/shop/adapter/out/persistence/AbstractCartRepositoryTest.java index 95abce5..55ed199 100644 --- a/adapter/src/test/java/eu/happycoders/shop/adapter/out/persistence/AbstractCartRepositoryTest.java +++ b/adapter/src/test/java/eu/happycoders/shop/adapter/out/persistence/AbstractCartRepositoryTest.java @@ -113,7 +113,7 @@ void givenExistingCartWithProduct_addProductAndSaveCart_updatesTheExistingCart() } @Test - void givenExistingCart_deleteById_deletesTheCart() { + void givenExistingCart_deleteByCustomerId_deletesTheCart() { CustomerId customerId = createUniqueCustomerId(); Cart existingCart = new Cart(customerId); @@ -121,17 +121,17 @@ void givenExistingCart_deleteById_deletesTheCart() { assertThat(cartRepository.findByCustomerId(customerId)).isNotEmpty(); - cartRepository.deleteById(customerId); + cartRepository.deleteByCustomerId(customerId); assertThat(cartRepository.findByCustomerId(customerId)).isEmpty(); } @Test - void givenNotExistingCart_deleteById_doesNothing() { + void givenNotExistingCart_deleteByCustomerId_doesNothing() { CustomerId customerId = createUniqueCustomerId(); assertThat(cartRepository.findByCustomerId(customerId)).isEmpty(); - cartRepository.deleteById(customerId); + cartRepository.deleteByCustomerId(customerId); assertThat(cartRepository.findByCustomerId(customerId)).isEmpty(); } diff --git a/application/src/main/java/eu/happycoders/shop/application/port/out/persistence/CartRepository.java b/application/src/main/java/eu/happycoders/shop/application/port/out/persistence/CartRepository.java index 03d5781..8762633 100644 --- a/application/src/main/java/eu/happycoders/shop/application/port/out/persistence/CartRepository.java +++ b/application/src/main/java/eu/happycoders/shop/application/port/out/persistence/CartRepository.java @@ -15,5 +15,5 @@ public interface CartRepository { Optional findByCustomerId(CustomerId customerId); - void deleteById(CustomerId customerId); + void deleteByCustomerId(CustomerId customerId); } diff --git a/application/src/main/java/eu/happycoders/shop/application/service/cart/EmptyCartService.java b/application/src/main/java/eu/happycoders/shop/application/service/cart/EmptyCartService.java index d766716..8f8b579 100644 --- a/application/src/main/java/eu/happycoders/shop/application/service/cart/EmptyCartService.java +++ b/application/src/main/java/eu/happycoders/shop/application/service/cart/EmptyCartService.java @@ -22,6 +22,6 @@ public EmptyCartService(CartRepository cartRepository) { public void emptyCart(CustomerId customerId) { Objects.requireNonNull(customerId, "'customerId' must not be null"); - cartRepository.deleteById(customerId); + cartRepository.deleteByCustomerId(customerId); } } diff --git a/application/src/test/java/eu/happycoders/shop/application/service/cart/EmptyCartServiceTest.java b/application/src/test/java/eu/happycoders/shop/application/service/cart/EmptyCartServiceTest.java index cacf6c0..3ce439f 100644 --- a/application/src/test/java/eu/happycoders/shop/application/service/cart/EmptyCartServiceTest.java +++ b/application/src/test/java/eu/happycoders/shop/application/service/cart/EmptyCartServiceTest.java @@ -18,6 +18,6 @@ class EmptyCartServiceTest { void emptyCart_invokesDeleteOnThePersistencePort() { emptyCartService.emptyCart(TEST_CUSTOMER_ID); - verify(cartRepository).deleteById(TEST_CUSTOMER_ID); + verify(cartRepository).deleteByCustomerId(TEST_CUSTOMER_ID); } }